README.md: Limit git submodule update to 1 layer - #3642
petecooper wants to merge 1 commit into
Conversation
limit `git submodule update` to 1 layer considerably reduces transfer amount and time taken
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe README now uses recursive submodule fetching with ChangesSubmodule fetching instructions
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Merge Risk: ⚪ Minimal · up to The README-only shallow-fetch change has no established merge-blocking risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
Hi @petecooper, thanks for this PR. I see the purpose of the change, but I have concerns about it. I compared the build environments (upstream/v3/master and your one). Pro: the downloaded size is less. Without your modification, the raw source size (after downloaded the submodules) is 669MB. With the modification it's only 157MB. Cons: To compare with the unpatched version, here is its output: I'm not sure this solution fits what you really want to reach. |
|
Understood. No drama. I'll close. |



Limit
git submodule updateto 1 layer deep.Considerably reduces data transfer & storage requirements, and time taken to complete operation
Fewer levels of
depth= fewer revisions downloaded = less data transfer & less time taken.Summary by CodeRabbit