Conversation
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
maschwenk
added
the
coder-task-generated
|
The following comment was made by an LLM, it may be inaccurate: |
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Related to anomalyco#39991
Type of change
What does this PR do?
The timeline error boundary used callback-form Show without keyed. If the query error cleared during navigation, the callback could call its disposed accessor and crash with Stale read from Show instead of surfacing the original query failure.
Adding keyed passes the resolved Error directly to the callback. The boundary can now throw the original error safely even if the condition changes during task or session teardown.
This targets v2-url-prefix because that is the integration branch pinned by Forge V2.
How did you verify your code works?
Prettier and oxlint pass for the changed file. The app package typecheck and the repository pre-push typecheck pass. The production failure was captured while switching Forge V2 tasks before this change.
Screenshots / recordings
Not applicable. This prevents an intermittent renderer crash without changing the rendered UI.
Checklist