Repository navigation
Small web platform cleanups - #3440
Open
david-crespo wants to merge 5 commits into
Open
david-crespo wants to merge 5 commits into
david-crespo wants to merge 5 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
david-crespo
commented
Nov 11, 2026
| transition-timing-function: cubic-bezier(0.4, 0, 0.2, 1); | ||
| transition-duration: 250ms; | ||
| .ox-table { | ||
| --sticky-col-shadow: light-dark(oklch(0 0 0 / 0.1), oklch(0 0 0 / 0.8)); |
Collaborator
Author
There was a problem hiding this comment.
@benjaminleonard you might want to tone down the light mode one. See the screenshot in the PR description. It may have been fine before. The dark mode one was invisible though.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These came out of a scan I did of the console with Chrome's Modern Web Guidance skill, which gives an agent a set of guides on current web platform features to check a codebase against. Each change is its own commit.
color-schemefrom the chosen theme. Our<meta name="color-scheme" content="dark light">tag tells the browser to pick a scheme from the OS preference, and the theme toggle only setdata-themeon<html>. So browser-drawn UI (native scrollbars, date pickers, autofill) followed the OS and not the chosen theme. With a light OS and the default dark theme, the side modal's scrollbar was drawn for a light page: a white track with classic scrollbars, or a dark thumb on the dark background with macOS overlay scrollbars. Nowdata-themealso sets thecolor-schemeCSS property.autoComplete="current-password"to the login form's password field. Password managers use it to tell a login form from a signup form. The username field already hadautoComplete="username".useIsOverflowhook that listened to scroll and resize events, throttled withlodash.throttle. They are now an animation tied to the table's horizontal scroll position withanimation-timeline: scroll(nearest inline), so the hook andlodash.throttleare gone. The shadow fades in over the first 2rem of scroll instead of snapping on. Scroll timelines need Chrome 115 (July 2023), Safari 26 (September 2025) or Firefox 159 (October 2026), which is only two weeks old. The rules are inside@supports, so older Firefox and Safari lose the shadows and nothing else. I think that is fine: the scrollbar is still always visible. The shadows were also very hard to see, especially in the dark theme, so I made them stronger.--content-quaternary, and--content-tertiaryon hover.uuidpackage. This one is not from the scan. The mock API now usescrypto.randomUUID(), which needs a secure context (HTTPS or localhost), as MSW's service worker already does. Toast IDs were the only use in the app itself, and I replaced those with a simple counter because the console is occasionally served over plain HTTP, e.g., from Nexus on a remote dev machine.uuid.validatein the mock API is replaced by a regex that matches any UUID version, as Nexus does.I also tried replacing SimpleBar with native
scrollbar-colorandscrollbar-width, which one of the guides recommends, and dropped it. SimpleBar was added in #1310 to keep the table's horizontal scrollbar visible so it's clear the table overflows. Firefox on macOS can't do that natively: overlay scrollbars hide until you scroll.I checked the shadows and the scrollbar thumb in Chromium in both themes, and that Firefox 151, which has no scroll timelines, shows no shadows.
color-scheme: light OS, dark themeBefore, the overlay scrollbar thumb on the right is dark on a dark background.
Scroll shadows
Table scrollbar thumb in light theme