Repository navigation
Drop unused dependencies - #3442
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing in the repo references these packages any more. The lockfile goes from 709 to 704 entries.
tsliband@react-router/nodestay installed as dependencies of other packages, so for those two this only tidiespackage.json. Lint, tsc, build, and the vitest suite pass. I did not run e2e locally.tslibcame from the Nx generator that created the repo (source), along withimportHelpers: truein tsconfig, which tells tsc to import helpers like__awaiterfrom tslib instead of inlining them. tsc never emitted our build (that was Babel, then Vite), but withimportHelperson, typechecking fails with TS2354 if tslib can't be resolved and the target needs a helper, as ours did while it was es2015. IP pool utilization #2078 raised the target to es2020 and Use tsgo, upgrade oxlint #3075 removedimportHelpers. It is still installed through@peculiar/x509and others.@tailwindcss/container-querieswas added in Instance Metrics using OxQL #2654 for the@containerand@[48rem]:variants on the instance metrics tabs, loaded as a plugin intailwind.config.ts. Tailwind 4 has container queries built in, and Tailwind 4 #2910 deleted the config file that loaded the plugin but left the package.@tanstack/react-query-devtoolswas added in Add react query devtools #1238 to show the React Query devtools panel in dev. It was commented out in cc67cff to keep it out of screenshots, and Use React Router framework mode + SPA mode #3400 deleted the commented-out lines.react-isand@types/react-isalso came from the Nx generator, which adds them alongside styled-components (source) because styled-components 5 has react-is as a peer dependency. We replaced styled-components with emotion in 451bef6.@reach/menu-button0.16 also had react-is as a peer dependency until Reach menu button -> Radix #1395 replaced it with Radix, and no package in the lockfile has had one since. Nothing in the repo has ever imported react-is, so the types were never used.@react-router/nodewas added in Use React Router framework mode + SPA mode #3400, following the React Router SPA guide, which says a project needs it for the build-time render ofindex.html. Ourentry.server.tsxuses web streams and doesn't import it, and@react-router/devalready depends on the exact same version, so it stays installed.