Repository navigation
Replace tunnel-rat with a portal - #3444
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
david-crespo
force-pushed
the
replace-tunnel-rat
branch
from
November 11, 2026 21:55
e400310 to
72dc096
Compare
david-crespo
enabled auto-merge (squash)
November 11, 2026 21:58
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tunnel-rat is how pagination and full-page form buttons get into the sticky footer of
ContentPane. It hasn't had a release since 2023 and it installs its own copy of zustand 4 next to our zustand 5. It was written to move elements between React renderers, which we don't need: we only have one renderer, socreatePortalis sufficient. This PR replaces the tunnel with aPageFootercomponent that portals its children into the footer element, whichContentPaneregisters in a small zustand store through a ref callback.Why it's better:
Potential issues and why they don't matter:
FullPageFormis the only user of page actions, and no full-page form has a paginated table.ContentPane. No page has a handler on an element around its table or form buttons, so nothing changes.Added an e2e test that navigates from the projects list into a project, to the instance create form, and back, checking that the footer shows pagination, then the form buttons, then pagination again.