Repository navigation
Conversation
The flattening helpers took a serde seq and rejected everything else at the data-model layer, so a tuple, a fixed-size array, a tuple struct, or a newtype struct around one of these failed to splice even though JSON writes each as an array. The serializer now treats serialize_tuple and serialize_tuple_struct like serialize_seq and forwards a newtype struct to its inner value; the deserializer visits the remaining elements for a tuple or tuple struct and forwards a newtype struct the same way. Variants stay rejected, since their tag is not part of an array.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The flattening helpers took a serde seq and rejected everything else at the data-model layer, so a tuple, a fixed-size array, a tuple struct, or a newtype struct around one of these failed to splice even though JSON writes each as an array. The serializer now treats serialize_tuple and serialize_tuple_struct like serialize_seq and forwards a newtype struct to its inner value; the deserializer visits the remaining elements for a tuple or tuple struct and forwards a newtype struct the same way. Variants stay rejected, since their tag is not part of an array.