Blueprint planner: refactor try_make_update() - #11283
Open
jgallagher wants to merge 1 commit into
Open
Conversation
Prior to this change, `try_make_update()` returned a (one-board-only) `PlannedMgsUpdate` that its caller inspected and then absorbed into the larger `PlannedMgsUpdates` it was building. Now, it returns an enum with explicit variants. This is a minor readability win today, but the main motivation is that the upcoming sled evacuation work will need `try_make_update()` to return variants that don't fit cleanly into `PlannedMgsUpdate` (i.e., "mark this sled for evacuation" and "make this evacuated sled available again").
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change,
try_make_update()returned a (one-board-only)PlannedMgsUpdatesthat its caller inspected and then absorbed into the largerPlannedMgsUpdatesit was building. Now, it returns an enum with explicit variants.This is a minor readability win today, but the main motivation is that the upcoming sled evacuation work will need
try_make_update()to return variants that don't fit as cleanly intoPlannedMgsUpdates(i.e., "mark this sled for evacuation" and "make this evacuated sled available again").