Replace switch backend variables with tagged deployment enum - #11286
Open
sion42x wants to merge 1 commit into
Open
Replace switch backend variables with tagged deployment enum#11286sion42x wants to merge 1 commit into
sion42x wants to merge 1 commit into
Conversation
Changes based on feedback in #11237. This method drastically simplifies the tracking of switch backend by sled-agent and improves downstream understanding by naming the types of configs. It also means no startup probe is run when `production` option (tofino) is chosen which is more in line with the current method. Current checked in configs are `production`, `virtual`, `standalone`, and `custom`.
Contributor
Author
|
@jmpesp I say old chap this does feel cleaner |
Contributor
Author
|
Succeeded on Madrid + voxel. On Madrid: |
Contributor
Author
|
On voxel: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes based on feedback in #11237. This method drastically simplifies the tracking of switch backend by sled-agent and improves downstream understanding by naming the types of configs. It also means no startup probe is run when
productionoption (tofino) is chosen which is more in line with the current method. Current checked in configs areproduction,virtual,standalone, andcustom.