standalone: should work without explicit CPUID profiles - #1218
Merged
Merged
Conversation
93e04e1 added support for selecting specific hypervisor interfaces to propolis-standalone, rather than the prior state of "guest always sees bhyve because of the 0x4000_0000 leaf default in vmm_cpuid.c". unfortunately, all my test VM configs include a `cpuid_profile`, so I missed that this change introduced a bug. given a configuration with the default CPUID leaves, the hypervisor interface leaves would get added and misconfigure guests to have all-zero CPUID leaves for every non-hypervisor leaf. many things go wrong; EDK2 sometimes will do bogus rdmsr and panic propolis on the unimplemented MSR. *if* you get past EDK2, GRUB checks for the TSC's presence via leaf 1 EDX[4], which is also clear. failing to find a TSC, GRUB gives up trying to boot. this change has propolis-standalone collect CPUID information more like propolis-server - do not rely on "default" resulting in an empty CPUID profile getting to bhyve, and instead at the point we decide to use a default profile, collect that from bhyve and explicitly provide it later.
Member
Author
|
Luiz tripped over this as the first person to |
lgfa29
approved these changes
Sep 18, 2026
lgfa29
left a comment
lgfa29
left a comment
Member
There was a problem hiding this comment.
Tested with the same setup that was failing before and it's working now 🥳
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
93e04e1 added support for selecting specific hypervisor interfaces to propolis-standalone, rather than the prior state of "guest always sees bhyve because of the 0x4000_0000 leaf default in vmm_cpuid.c".
unfortunately, all my test VM configs include a
cpuid_profile, so I missed that this change introduced a bug. given a configuration with the default CPUID leaves, the hypervisor interface leaves would get added and misconfigure guests to have all-zero CPUID leaves for every non-hypervisor leaf.many things go wrong; EDK2 sometimes will do bogus rdmsr and panic propolis on the unimplemented MSR. if you get past EDK2, GRUB checks for the TSC's presence via leaf 1 EDX[4], which is also clear. failing to find a TSC, GRUB gives up trying to boot.
this change has propolis-standalone collect CPUID information more like propolis-server - do not rely on "default" resulting in an empty CPUID profile getting to bhyve, and instead at the point we decide to use a default profile, collect that from bhyve and explicitly provide it later.