Conversation
kdeldycke
force-pushed
the
deprecate-non-identifier-names
branch
from
September 11, 2026 13:35
62cff1d to
3c5be86
Compare
Member
|
What do you think, should we also check |
Collaborator
Author
Ah. That might be a good idea: test drive that check during a long 8.x cycle and see if it show up... If I implement this, what kind of severity should it triggers? A |
Member
|
Deprecation seems fine. Like I said in the other thread, it could be more disruptive, but it also seems to match the intention of the |
Prepares the ground for pallets#3827 and future 9.0.0 release
kdeldycke
force-pushed
the
deprecate-non-identifier-names
branch
from
September 11, 2026 14:24
3c5be86 to
eb37bea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prepares the ground for #3827, which is going to refuse parameter names that are not valid Python identifiers.
Of course, I fucked-up the same way I fucked-up 2 months ago with #3701 , when juggling between
mainandstablebranches made me push tostable. 😫So:
stablewith d036881Now, for the PR itself: this contain additional
DeprecationWarningthat detect whenParameter,ArgumentorOptiongets anamethat will be not allowed in the future 9.0.0 release. I.e. when these parameters are not Python identifier according tostr.identifier.This PR also copy the majority of tests that were originally proposed in #3827, so the behavior of the
nameis locked down and frozen. This will prevent tweaking or introducing regressions during the full 8.x cycle.