Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 40 additions & 1 deletion app/src/__tests__/forms-panels.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { FormsInspector } from '../pages/forms-inspector';
import { FormsLint, FormsSubmit } from '../pages/forms-report';
import { FormsTimeline } from '../pages/forms-timeline';
import { FormsWebMcp } from '../pages/forms-webmcp';
import type { CollectedForm, FormFieldNode } from '../pages/forms-types';
import type { CollectedForm, FormEvent, FormFieldNode } from '../pages/forms-types';

type Call = (name: string, arg: Record<string, unknown>) => Promise<unknown>;

Expand Down Expand Up @@ -843,6 +843,45 @@ describe('FormsInspector selection', () => {
});
});

describe('FormsInspector timeline', () => {
it('passes every kept event of the form to the timeline when limits.formTimeline is raised', async () => {
const events: FormEvent[] = Array.from({ length: 300 }, (_, i) => ({
formId: form.id,
path: i < 50 ? 'name' : 'email',
type: 'value',
seq: i + 1,
timestamp: 1000 + i,
}));
const rpc = {
call: () => Promise.resolve('ok'),
callEvent: () => Promise.resolve(),
sharedState: () =>
Promise.resolve({ value: () => ({ forms: [form], events }), on: () => () => {} }),
};
const client = {
connectionMeta: { configs: { pangular: { limits: { formTimeline: 500 } } } },
scope: () => ({ rpc }),
} as unknown as DevframeRpcClient;
const fixture = TestBed.createComponent(FormsInspector);
fixture.componentRef.setInput('rpc', client);
document.body.append(fixture.nativeElement);
await settle(fixture);
fixture.componentInstance.tab_.set('timeline');
await settle(fixture);
expect(text(fixture)).toContain('Showing the latest 100 of 300 events');

const host = fixture.nativeElement as HTMLElement;
const search = host.querySelector<HTMLInputElement>(
'input[aria-label="Filter by field path"]',
)!;
search.value = 'name';
search.dispatchEvent(new Event('input'));
await settle(fixture);
expect(text(fixture)).toContain('50 of 300 events');
expect(host.querySelectorAll('.events li')).toHaveLength(50);
});
});

describe('FormsTimeline', () => {
it('leaves the Record details checkbox on the reported state until the page confirms', async () => {
const fixture = TestBed.createComponent(FormsTimeline);
Expand Down
4 changes: 1 addition & 3 deletions app/src/pages/forms-inspector.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1448,9 +1448,7 @@ export class FormsInspector {

readonly selectedEvents = computed(() => {
const id = this.selected()?.id;
return this.events()
.filter((e) => e.formId === id)
.slice(-200);
return this.events().filter((e) => e.formId === id);
});

constructor() {
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion extension/ui/index.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading