Correct imageSize in the image contract, which is a string - #30
Merged
Conversation
Every provider that implements ImageProviderInterface names its own sizes, and they are all strings: "1K", "2K" and "4K" on Google, "1024x1024" on OpenAI. The docblock said int, which no implementation has ever honoured. Google's provider passes "2K" today, so Psalm rejected the implementation as soon as the provider's own docblock was made honest. Correcting the contract rather than the provider closes it at the source. Docblock only, so no behaviour changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ImageProviderInterfacedeclaredimageSize?: inton bothgenerateImage()andeditImage(). No provider has ever honoured that: every provider names its own sizes and they are all strings. Google takes"1K","2K"and"4K"; OpenAI takes"1024x1024".This surfaced while fixing image generation in
papi-ai/google. As soon as that provider's own docblock was corrected tostring, Psalm rejected the implementation for not matching the interface, which is the contract pointing at its own error.Correcting the contract rather than bending the provider back to
intcloses it at the source, and stops the next provider that implements this interface from inheriting the same wrong hint.Docblock only. No behaviour changes, no signature changes, so this is a patch.