refactor(polkavm): isolate optional host composition - #540
Conversation
7f73849 to
f6457f1
Compare
|
@pgherveou @eugypalu all required checks are green, including Rust/Clippy, Android, iOS, browser artifacts, and license policy. Could one of you provide the required host-sdk-team approval so the merge queue can admit this dependency? |
pgherveou
left a comment
There was a problem hiding this comment.
can we remove the generated files in the new js packages. Can't these be built from the src files ?
for the new bindings we can also added then to .gitattributes with linguist-generated=true, so that at least they show up as generated artifacts in the code review
|
Addressed in b0e178e: removed the committed browser |
|
Cleanup CI is fully green; ready for rereview and merge queue admission. |
|
DQ: why do all these things need to live in host-rust-core, they don't seem to have dependency on the rust-core stuff, and could be shipped independently ? |
b0e178e to
e0f05c4
Compare
|
They share the Rust core directly rather than only co-locating artifacts:
They could be split, but that would duplicate the Rust source/pins and create independent browser, XCFramework, and AAR versioning with an ABI-drift boundary. Keeping the runtime here makes the host-neutral Rust implementation the single source for all three targets; Epoca/Dotli/Brevity/Desktop remain independent consumers. |
|
Does that shared Rust/UniFFI dependency path resolve the repository-placement concern, or do you want the runtime split into a separate repository before merge? |
|
Additional review completed. Fixed three concrete boundary issues:
Added behavioral browser tests for malformed launch inputs and cross-profile framebuffer submission. Full workspace result: 1,205 tests passed, Clippy Vendored commit |
|
PolkaVM dependency update:
|
build(pvm): pin standalone runtime v0.1.10
…pvm-app-runtime # Conflicts: # Cargo.lock # rust/crates/truapi-pvm-host/Cargo.toml # rust/crates/truapi-pvm-host/src/lib.rs
be4d0c2 to
5c8e341
Compare
5c8e341 to
60e9de3
Compare
Summary
truapi-pvm-hostwith the optionaltruapi-polkavm-host0.2.0 composition cratepolkavm-host-runtime0.2.0 at30770959f66db81d46163f70f72f83f1a5507f6dtruapi-servercompletely independent of PolkaVMarmeabi-v7aBoundary
truapi-polkavm-hostis an rlib-only composition dependency. It explicitly exposes the namespacedpolkavm_host_runtimeandtruapi_serverAPIs plus pinned version/revision constants. Downstream distribution crates decide which native ABI surfaces to export.Verification
cargo test -p truapi-polkavm-host --lockedcargo clippy -p truapi-polkavm-host --all-targets --locked -- -D warningscargo fmt --all -- --checkcargo tree -p truapi-server --lockedcontains no PolkaVM dependency