refactor: Bump js-yaml from 4.1.1 to 4.3.2 - #3469
Conversation
|
🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review. Tip
Note Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect. Caution Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe lockfile updates the resolved Changesjs-yaml dependency update
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: ⚪ Minimal · up to This update resolves the named advisories, and the remaining development dependency is not affected by them. No actionable merge risk is identified. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Pull Request
Issue
Fixes the root
js-yaml4.x copy for these Dependabot security alerts:js-yaml>= 4.0.0, < 4.3.2maxTotalMergeKeysdoes not limit CPU use for empty merge sourcesjs-yaml>= 4.0.0, < 4.3.1!!omapresolutionjs-yaml>= 4.0.0, < 4.3.0js-yaml>= 4.0.0, <= 4.1.1The dependency is development-only. The nested 3.x copy under
@istanbuljs/load-nyc-configwas already updated to 3.15.2 in #3451.Approach
Bumps the transitive dev dependency
js-yamlfrom 4.1.1 to 4.3.2, the latest 4.x release (npm update js-yaml --package-lock-only --ignore-scripts). The change is limited to the lock file.Lock file changes:
js-yaml4.1.1 → 4.3.2:node_modules/js-yaml(dev). Its only dependency,argparse^2.0.1, is unchanged. npm also adds the package's newfundingfield.node_modules/@istanbuljs/load-nyc-config/node_modules/js-yaml3.15.2 is unchanged.Usage in this project: the parents of the root copy only load
js-yamllazily, when they read a YAML config file, and none of them reads one in this repository:@eslint/eslintrc(througheslint9.39.2) parses YAML only for legacy.eslintrc.yaml,.eslintrc.ymland.eslintrcfiles. The repository uses the flat configeslint.config.jsand has no.eslintrc*files.cosmiconfig(throughsemantic-release, the nestedsemantic-releaseof@saithodev/semantic-release-backmerge, andpuppeteer) parses YAML only for YAML config files. semantic-release finds.releaserc.js..releaserc/is a folder of.hbstemplates, which cosmiconfig skips (EISDIR). There is no.puppeteerrc*file and noreleaseorpuppeteerkey inpackage.json.webpack-clihas an optional peer dependency onjs-yamlfor YAML webpack configs. All webpack configs inwebpack/are.jsfiles..github/dependabot.yml,.github/ISSUE_TEMPLATE/config.yml,.github/workflows/*.yml,docker-compose.uffizzi.yml,.prettierrc) are not read by these tools.ci/CiVersionCheck.mjsparses YAML with theyamlpackage, notjs-yaml.The parser changes below therefore cannot affect this project.
Changes
<<) by deduplicating repeated elements (GHSA-h67p-54hq-rp68).maxDepth(100) andmaxMergeSeqLength(20) loader options.maxTotalMergeKeys(10000) loader option, which limits the total number of keys processed by YAML merge (<<) in oneload()/loadAll()call, and replacesmaxMergeSeqLength(GHSA-52cp-r559-cp3m). Restores the UMD builds to ES5.!!omapduplicate key detection (GHSA-5p4m-2wfm-xmqj).maxTotalMergeKeys(fix: count empty merge sources against maxTotalMergeKeys nodeca/js-yaml#797, GHSA-2883-xcg3-v3hh).The package entry points (
exports,main,module) and theload()API are unchanged.Breaking Changes
None. The stricter parsing in 4.2.0 only applies to YAML documents, and none of the parents parses YAML in this repository (see Usage above).
Code Changes Required
None. This is a drop-in replacement.
Tasks
N/A. This is a lock-file-only dependency update.
Summary by CodeRabbit