refactor: Correct under-reported code coverage for Options/parsers#10559
refactor: Correct under-reported code coverage for Options/parsers#10559dblythy wants to merge 1 commit into
Conversation
|
🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review. Tip
Note Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect. Caution Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code. |
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 3 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## alpha #10559 +/- ##
==========================================
+ Coverage 92.66% 92.89% +0.22%
==========================================
Files 193 193
Lines 16981 16980 -1
Branches 248 248
==========================================
+ Hits 15736 15774 +38
+ Misses 1224 1185 -39
Partials 21 21 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
buildConfigDefinitions imported parsers from ../src/Options/parsers at module scope. Loading it in a spec instruments the real src file a second time (top level only), colliding with the sourcemap-remapped lib coverage from parsers.spec.js and clobbering it down to ~2.5%. Move the require into parseDefaultValue, its only consumer, so the module reports its true 100%.
d114402 to
720da56
Compare
Issue
src/Options/parsers.jsreports ~2.5% coverage on Codecov even thoughspec/parsers.spec.jsfully covers it.Approach
Turns out it's a coverage measurement artifact, not missing tests.
resources/buildConfigDefinitions.jsimportedparsersfrom../src/Options/parsersat module scope. When the spec loads that tooling, nyc instruments the realsrc/file a second time (only the top level runs, the parser functions are never called on that path), and that collides with the sourcemap-remappedlib/coverage coming fromparsers.spec.js, clobbering it down to ~2.5%.mapperFor(the only thing the spec imports) doesn't useparsersanyway - onlyparseDefaultValuedoes. Moving the require in there drops the module-scopesrcinstrumentation, so the file reports its true 100% and the generator still works.Verified by loading
parsers.spec.js+buildConfigDefinitions.spec.jstogether: 40/40 lines with the change, 1/40 without.Tasks
spec/parsers.spec.js)