ci: Exclude build tooling (resources/) from coverage#10561
Conversation
resources/buildConfigDefinitions.js is a build-time codegen tool, not shipped runtime code. Its generation pipeline only runs on direct execution (require.main === module), so it can't be exercised by the test suite, and it only exports mapperFor. Measuring it reports ~19% and drags the project coverage number down for code that isn't part of the product. Exclude resources/** from nyc instrumentation.
|
🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review. Tip
Note Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect. Caution Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code. |
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 18 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## alpha #10561 +/- ##
==========================================
+ Coverage 92.66% 93.53% +0.86%
==========================================
Files 193 192 -1
Lines 16981 16786 -195
Branches 248 248
==========================================
- Hits 15736 15701 -35
+ Misses 1224 1064 -160
Partials 21 21 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Issue
resources/buildConfigDefinitions.jsis a build-time codegen tool (run vianpm run definitions), not shipped runtime code. It's currently measured for coverage at ~19% (158 uncovered lines), which drags the project coverage number down for something that isn't part of the product.Approach
Exclude
resources/**from nyc instrumentation. The bulk of the file is the codegen pipeline plus the file-read/write block guarded byif (require.main === module), which only runs on direct execution and can't be exercised by the test suite (the module only exportsmapperFor). Excluding build tooling from coverage is standard practice and reflects the project number on product code only.Tasks