Repository navigation
[Deps] Clear toml DoS advisories via react-doctor refresh - #1127
Merged
Merged
Conversation
react-scan@0.5.7 depends on react-doctor@latest, which was locked at 0.5.0 and pulled effect@4.0.0-beta.70 -> toml@4.1.1 (GHSA-4qx8-w7c3-pj3p, GHSA-9j65-hcg3-gc64, GHSA-9qmh-m7c6-f92p). react-doctor 0.9.18 no longer depends on effect. Lockfile-only change via `bun update react-doctor`.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes the vulnerable
toml@4.1.1frombun.lockby refreshing the transitivereact-doctorresolution from 0.5.0 to 0.9.18. This is a lockfile-only change: nopackage.json, override or app code edits.High-severity advisories cleared (all
toml <=5.0.0, CPU DoS intoml.parse(), published 2026-10-22):The same
toml@4.1.1also carried two older high advisories, which this clears too: GHSA-82x6-q7mm-w9cf and GHSA-v5mp-jgw5-2x6j.Dependency chain (verified against the lockfile):
apps/editordevDependencyreact-scan@^0.5.7→react-doctor(declared as"latest"by react-scan, locked at 0.5.0) →effect@4.0.0-beta.70→toml@^4.1.1.effecthad no other consumer. react-doctor 0.9.18 no longer depends oneffect.Exposure was dev-only. react-scan is an
apps/editordevDependency, loaded only whenNODE_ENV=developmentandPASCAL_DEV_DIAGNOSTICS=1. Its browser bundle never imports react-doctor; it only embeds the package.json metadata. The react-scan CLI runsnpx react-doctor@latestrather than the locked copy.Lockfile changes (
bun update react-doctor, bun 1.4.4):react-doctor0.5.0 → 0.9.18;oxlint-plugin-react-doctor0.5.0 → 0.9.18toml,effect,@effect/platform-node-shared,deslop-js,fast-check,pure-rand,find-my-way-ts,ini,kubernetes-types,msgpackr(+msgpackr-extractbinaries),multipasta,uuid@14,ws,@types/ws,@standard-schema/spec, thevscode-languageserver*/vscode-jsonrpc/vscode-urifamily,node-gyp-build-optional-packages@astrojs/compiler,playwright-core,yoga-layout,@shaderfrog/glsl-parser, a nestedlightningcss@1.33.0underoxlint-plugin-react-doctor,react-doctor/typescript@5.9.3oxlint1.69 → 1.81,oxc-parser0.132 → 0.148,oxc-resolver11.20 → 11.24.2 (and their native bindings), plus their wasm runtime helpers@napi-rs/wasm-runtime,@emnapi/*,@tybys/wasm-util@babel/*,@floating-ui/*and others was tried and rejected.bun audit: 38 → 33 advisories (32 → 27 high). None of the remaining ones involve toml or react-doctor's subtree.How to test
bun install --frozen-lockfile. It should succeed with no lockfile changes, andgrep '"toml"' bun.lockshould return nothing.bun audit. Notomlentries should remain.PASCAL_DEV_DIAGNOSTICS=1 bun dev, then open the editor. The react-scan overlay should appear:window.__REACT_SCAN__and#react-scan-rootare present.Screenshots / screen recording
N/A — non-visual change
Checklist
bun devbun checkto verify)mainbranchNote
Low Risk
Dev-only lockfile churn for a transitive CLI/tooling package; runtime and production bundles are unaffected, though CI/local installs pull a larger new dependency tree.
Reviewed by Cursor Bugbot for commit 5e9fec1. Bugbot is set up for automated code reviews on this repo. Configure here.