Skip to content

Keep table and list actions tied to the correct business entity - #81

Merged
Narrator merged 3 commits into
mainfrom
codex/sprint1-portable-targets
Oct 26, 2026
Merged

Narrator merged 3 commits into
mainfrom
codex/sprint1-portable-targets

Conversation

@Narrator

Copy link
Copy Markdown
Member

Row actions could retain an exact handle after a virtualized DOM slot changed to another invoice/customer, because sibling business text was absent from target identity. Ordinary unlabeled table/list actions also remained ambiguous across sessions. Capture semantic row text as conjunctive scope identity, retire changed local handles, and safely refuse duplicate, redacted, over-limit or overflowing portable scopes. Preserve complete raw ancestor identity privately and redact split PII before segment encoding. No schema or dependency changes.

Validation:

  • Meaningful RED/GREEN regressions reproduce the original stale-handle/portable-replay failures and independent review findings involving scope overflow and split email/card/phone data. Review and re-review found no remaining material findings.
  • Uncached configured lint/test/build/typecheck/sync-dist: 2,128 tests across 119 files pass; runtime 582 tests. Two pre-existing styling-fixture lint warnings remain. Direct runtime/harness lint, formatting and syntax pass.
  • Fresh Next16/pnpm table and Vue3/pnpm/Vite5 list consumers pass nine real-browser checks each: exact source/runtime, genuinely retained DOM nodes, intended-entity updates, persisted fresh-session replay, ambiguity refusal, zero app errors, and production stripping. The original React18/npm/Vite7 article path also passed. CI retains eight representative consumers and exercises semantic rows in two.
  • Three maintained-app workflows are documented using the Next website and upstream Vue TodoMVC. TodoMVC requires an explicit supported Vite7 pin: upstream Vite8 plus Domscribe currently fails peer resolution. Website functional checks pass with local-host Vercel metrics 404s retained separately. See docs/real-app-acceptance.md.

Conservative limits: changed visible row text can require recapture; more than four identified scopes or long/redacted identity refuses portable replay. Main-document/light-DOM and explicit-step limits remain. Local tarballs contain unpublished APIs; this does not publish a release or establish agent efficiency/demand.

@Narrator
Narrator marked this pull request as ready for review October 26, 2026 20:23
@nx-cloud

nx-cloud Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit e02af8e

Command Status Duration Result
nx run domscribe-test-fixtures:install-fixture-... ✅ Succeeded 12s View ↗
nx run domscribe-test-fixtures:integration--web... ✅ Succeeded 2m 58s View ↗
nx run domscribe-test-fixtures:integration--web... ✅ Succeeded 2m 52s View ↗
nx run domscribe-test-fixtures:integration--web... ✅ Succeeded 2m 48s View ↗
nx run domscribe-test-fixtures:integration--web... ✅ Succeeded 2m 48s View ↗
nx run domscribe-test-fixtures:integration--vit... ✅ Succeeded 46s View ↗
nx run domscribe-test-fixtures:install-fixture-... ✅ Succeeded 48s View ↗
nx run domscribe-test-fixtures:install-fixture-... ✅ Succeeded 18s View ↗
Additional runs (18) ✅ Succeeded ... View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-10-26 20:41:27 UTC

@Narrator
Narrator merged commit 4350b6f into main Oct 26, 2026
40 checks passed
@Narrator
Narrator deleted the codex/sprint1-portable-targets branch October 26, 2026 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant