Repository navigation
feat!: regenerate patternfly icon set from PatternFly v6 sources - #30
Draft
bennypowers wants to merge 1 commit into
Draft
bennypowers wants to merge 1 commit into
bennypowers wants to merge 1 commit into
Conversation
Updates the build to import pficons from @patternfly/patternfly v6 (icons/pficons.mjs), which replaces the removed v4-era pf-icons.json and adds the new v6 icons: multicluster, treeview, the six severity icons, and pen-to-square. Renames the custom icon modules from camelCase to kebab-case for parity with @patternfly/react-icons, and switches the JSON import assertion syntax from assert to with for Node 22 compatibility. The fontawesome sets are unchanged. Assisted-By: Claude Code <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 82f95b6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Implements #29. Regenerates the
patternflyicon set from PatternFly v6 sources and releases it as v2.0.0.pfIconsfrom@patternfly/patternfly/icons/pficons.mjs(v6), replacing the removed v4-erapf-icons.json, and bumps the devDependency to^6.6.1multicluster,treeview, the sixseverity-*icons, andpen-to-square@patternfly/react-icons:ansibeTowertoansibe-tower,chartSpiketochart-spike,cloudCircletocloud-circle,cloudServertocloud-server,paperPlaneAlttopaper-plane-alt,svgPathDataMissingtopath-missing-altrename map and thehistorydeletion, matching react-icons exactlyasserttowithfor Node 22 compatibilityThe
fas,far, andfabsets regenerate unchanged (1001, 151, and 456 modules, identical to 1.0.3).The build produces 143 modules in the
patternflyset: 135 pficons (136 in v6 minushistory) plus 10 custom icons, withopenshiftandopenstackdefined in both sources (the custom definitions win, as in react-icons). The issue estimated 145 before accounting for that overlap.Testing Instructions
npm ci && npm run buildpatternflyset contains 143 modules, includingmulticluster,treeview,severity-criticalthroughseverity-undefined, andpen-to-squareRed Hat, Inc. MITfor the patternfly set,fontawesome. CC-BY-4.0for FA sets) and viewBoxhistoryand the camelCase module names are absentNotes to Reviewers
@patternfly/icons/patternfly/<name>.jsby the old camelCase names break, hence the major bump;fas,far, andfabconsumers are unaffected<pf-v6-icon>patternfly-elements#3164 (thepf-v6-iconport) uses the defaultfasset today and will bump to^2when this ships🤖 Generated with Claude Code