Skip to content

refactor(server): pf-4401 centralize child-process, ipc, host #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cdcabrera merged 5 commits into from
Jul 29, 2026
Merged

refactor(server): pf-4401 centralize child-process, ipc, host #262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c60a000
refactor(server): pf-4401 centralize child-process, ipc, host
cdcabrera Jul 23, 2026
f36c9f8
fix: review update
cdcabrera Jul 29, 2026
b5651db
fix: review update
cdcabrera Jul 29, 2026
bbf5564
fix: review update
cdcabrera Jul 29, 2026
ead289b
fix: review update
cdcabrera Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
160 changes: 49 additions & 111 deletions src/__tests__/__snapshots__/server.tools.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,32 +16,21 @@ exports[`composeTools should attempt to setup creators, file package creators 1`

exports[`composeTools should attempt to setup creators, file package creators, Node.js 22 1`] = `
{
"log": [
[
"Existing Tools Host session detected test-session-id. Shutting down the existing host before creating a new one.",
],
],
"log": [],
"toolsCount": 5,
}
`;

exports[`composeTools should attempt to setup creators, file package creators, Node.js 24 1`] = `
{
"log": [
[
"Existing Tools Host session detected test-session-id. Shutting down the existing host before creating a new one.",
],
],
"log": [],
"toolsCount": 5,
}
`;

exports[`composeTools should attempt to setup creators, file package creators, Node.js undefined 1`] = `
{
"log": [
[
"Existing Tools Host session detected test-session-id. Shutting down the existing host before creating a new one.",
],
[
"External tool plugins require Node >= 22; skipping file-based tools.",
],
Expand All @@ -53,9 +42,6 @@ exports[`composeTools should attempt to setup creators, file package creators, N
exports[`composeTools should attempt to setup creators, file package duplicate creators 1`] = `
{
"log": [
[
"Existing Tools Host session detected test-session-id. Shutting down the existing host before creating a new one.",
],
[
"Skipping tool plugin "@patternfly/tools" – name already used by built-in/inline tool.",
],
Expand All @@ -66,21 +52,14 @@ exports[`composeTools should attempt to setup creators, file package duplicate c

exports[`composeTools should attempt to setup creators, inline and file package creators 1`] = `
{
"log": [
[
"Existing Tools Host session detected test-session-id. Shutting down the existing host before creating a new one.",
],
],
"log": [],
"toolsCount": 7,
}
`;

exports[`composeTools should attempt to setup creators, inline and file package creators duplicate builtin creators 1`] = `
{
"log": [
[
"Existing Tools Host session detected test-session-id. Shutting down the existing host before creating a new one.",
],
[
"Skipping inline tool "loremipsum" because a tool with the same name is already provided (built-in or earlier).",
],
Expand All @@ -95,9 +74,6 @@ exports[`composeTools should attempt to setup creators, inline and file package
exports[`composeTools should attempt to setup creators, inline and file package creators, duplicates 1`] = `
{
"log": [
[
"Existing Tools Host session detected test-session-id. Shutting down the existing host before creating a new one.",
],
[
"Skipping tool plugin "@patternfly/tools" – name already used by built-in/inline tool.",
],
Expand All @@ -112,9 +88,6 @@ exports[`composeTools should attempt to setup creators, inline and file package
exports[`composeTools should attempt to setup creators, inline and file package creators, duplicates, Node.js 22 1`] = `
{
"log": [
[
"Existing Tools Host session detected test-session-id. Shutting down the existing host before creating a new one.",
],
[
"Skipping tool plugin "@patternfly/tools" – name already used by built-in/inline tool.",
],
Expand Down Expand Up @@ -175,7 +148,7 @@ exports[`composeTools should return default creators on tools host error 1`] = `
{
"log": [
[
"Failed to start Tools Host; skipping externals and continuing with built-ins/inline. undefined",
"Failed to start Tools Host; skipping externals and continuing with built-ins/inline. Error: Mock spawn failure",
],
],
"toolsCount": 3,
Expand Down Expand Up @@ -410,54 +383,54 @@ exports[`logWarningsErrors should log warnings and errors, with warnings only 1`

exports[`makeProxyCreators should attempt to invoke a creator then throw an error on child response, ok false with error: handler 1`] = `[Error: Error message]`;

exports[`makeProxyCreators should attempt to invoke a creator then throw an error on child response, ok false with error: send 1`] = `
exports[`makeProxyCreators should attempt to invoke a creator then throw an error on child response, ok false with error: request 1`] = `
[
[
undefined,
{
"args": {
"loremIpsum": 7,
},
"id": "id-1",
"t": "invoke",
"toolId": "loremIpsum",
},
"invoke:result",
10,
],
]
`;

exports[`makeProxyCreators should attempt to invoke a creator then throw an error on child response, ok false with full error: handler 1`] = `[Error: Error message]`;

exports[`makeProxyCreators should attempt to invoke a creator then throw an error on child response, ok false with full error: send 1`] = `
exports[`makeProxyCreators should attempt to invoke a creator then throw an error on child response, ok false with full error: request 1`] = `
[
[
undefined,
{
"args": {
"loremIpsum": 7,
},
"id": "id-1",
"t": "invoke",
"toolId": "loremIpsum",
},
"invoke:result",
10,
],
]
`;

exports[`makeProxyCreators should attempt to invoke a creator then throw an error on child response, ok false: handler 1`] = `[Error: Tool invocation failed]`;

exports[`makeProxyCreators should attempt to invoke a creator then throw an error on child response, ok false: send 1`] = `
exports[`makeProxyCreators should attempt to invoke a creator then throw an error on child response, ok false: request 1`] = `
[
[
undefined,
{
"args": {
"loremIpsum": 7,
},
"id": "id-1",
"t": "invoke",
"toolId": "loremIpsum",
},
"invoke:result",
10,
],
]
`;
Expand Down Expand Up @@ -577,97 +550,62 @@ exports[`makeProxyCreators should attempt to return proxy creators, a function w
}
`;

exports[`sendToolsHostShutdown should attempt force shutdown of child and fail NaN`] = `
[
[
"Failed to send shutdown signal to Tools Host child process: Error: Mock send failure",
],
[
"Failed to force-kill Tools Host child process: Error: Mock failed to kill child process",
],
[
"Failed to close Tools Host stderr reader: Error: Mock close failure 1",
],
[
"Slow shutdown response. Primary fallback force-killing Tools Host child process.",
],
]
`;

exports[`spawnToolsHost attempt to spawn the Tools Host, with no pluginIsolation, node 24: spawn 1`] = `
{
"spawn": [
[
"/mock/path/to/toolsHost.js",
],
{
"stdio": [
"ignore",
"pipe",
"pipe",
"ipc",
],
"spawnConfig": {
"enableStderrDebug": [Function],
"importSpecifier": "#toolsHost",
"isolation": {
"fsReadAllowlist": [],
"mode": "none",
"nodeVersion": 24,
},
],
"label": "Tools Host",
},
}
`;

exports[`spawnToolsHost attempt to spawn the Tools Host, with strict pluginIsolation, node 22: spawn 1`] = `
{
"spawn": [
[
"--experimental-permission",
"--allow-fs-read=/",
"--allow-fs-read=/mock/path/to",
"/mock/path/to/toolsHost.js",
],
{
"stdio": [
"ignore",
"pipe",
"pipe",
"ipc",
],
"spawnConfig": {
"enableStderrDebug": [Function],
"importSpecifier": "#toolsHost",
"isolation": {
"fsReadAllowlist": [],
"mode": "strict",
"nodeVersion": 22,
},
],
"label": "Tools Host",
},
}
`;

exports[`spawnToolsHost attempt to spawn the Tools Host, with strict pluginIsolation, node 24: spawn 1`] = `
{
"spawn": [
[
"--permission",
"--allow-fs-read=/",
"--allow-fs-read=/mock/path/to",
"/mock/path/to/toolsHost.js",
],
{
"stdio": [
"ignore",
"pipe",
"pipe",
"ipc",
],
"spawnConfig": {
"enableStderrDebug": [Function],
"importSpecifier": "#toolsHost",
"isolation": {
"fsReadAllowlist": [],
"mode": "strict",
"nodeVersion": 24,
},
],
"label": "Tools Host",
},
}
`;

exports[`spawnToolsHost attempt to spawn the Tools Host, with undefined pluginIsolation, node 22: spawn 1`] = `
{
"spawn": [
[
"/mock/path/to/toolsHost.js",
],
{
"stdio": [
"ignore",
"pipe",
"pipe",
"ipc",
],
"spawnConfig": {
"enableStderrDebug": [Function],
"importSpecifier": "#toolsHost",
"isolation": {
"fsReadAllowlist": [],
"mode": "none",
"nodeVersion": 22,
},
],
"label": "Tools Host",
},
}
`;
Loading
Loading