chore(docs): Adjust spacing - #5103
Open
rebeccaalpert wants to merge 3 commits into
Open
Conversation
Collaborator
rebeccaalpert
marked this pull request as ready for review
August 25, 2026 20:27
kmcfaul
reviewed
Aug 27, 2026
kmcfaul
left a comment
kmcfaul
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me overall, only saw two spacing issues:
- Tables that precede other content don't have gap.
- Props table section doesn't have a gap if its preceded by something other than a code editor example. Maybe worth putting a one-off class on the Props table
h2, or targeting the lasth2on the page for additional padding.
rebeccaalpert
force-pushed
the
spacing
branch
4 times, most recently
from
August 27, 2026 20:32
30399be to
8910c98
Compare
We used to determine the gutter based on whether items were component docs - this brings that back so we can adjust where margins are used. Fixes patternfly#4257 Assisted-by: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used to determine the gutter based on whether items were component docs - this brings that back so we can adjust where margins are used.
I don't know the full history, but it was removed here: https://github.com/patternfly/patternfly-org/pull/4127/changes#diff-da135efaa2b01f501f1ac196874e6c6ae745345196f59a4581445639bf5384c4R94
I don't know if there's a reason why I shouldn't bring it back - please tell me!
Fixes #4257
Assisted-by: Cursor