Repository navigation
Conversation
Collaborator
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #5118
Updates
useIsStuck.jsto useuseLayoutEffectwhen there is a browser window anduseEffectwhen there isn't (for the prerendering step of the build), which suppresses all of the warnings the build was throwing.Also took a stab at improving the dynamic sticky tabs behavior. The existing behavior is often flaky. It doesn't always make the tabs sticky when scrolling fast, landing on/going to page anchors, and other random times.
From the robots, this PR updates
useIsStuck.jsto:scrollElement.scrollTopwithstickyElement.offsetTop.scrollTopis relative to the scrolling container, whileoffsetTopis relative to the element’s offset parent; those aren’t necessarily the same coordinate system. The hook now compares the tabs’ rendered top with the scrollport’s rendered top, so it checks whether the tabs are actually stuck at the container’s edge.resizeevent listener to handle sticky behavior when the window resizes, which is most relevant on pages with a lot of content (that wraps differently on resize) above the tabs.