fix(gosdk): reject empty JSON responses - #632
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #632 +/- ##
=======================================
Coverage 99.87% 99.87%
=======================================
Files 296 296
Lines 37147 37175 +28
=======================================
+ Hits 37101 37129 +28
Misses 27 27
Partials 19 19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
daveshanley
force-pushed
the
codex/sdk-empty-json
branch
3 times, most recently
from
September 22, 2026 03:22
8c0dd89 to
77eabee
Compare
daveshanley
force-pushed
the
codex/sdk-empty-json
branch
from
September 22, 2026 03:30
77eabee to
888c4d9
Compare
daveshanley
marked this pull request as ready for review
September 22, 2026 11:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A generated method with a declared JSON success response currently accepts an empty body and returns a zero-value model. Reject the missing payload as a
ResponseDecodeError, preserving status, headers, and body for diagnosis.Validation:
go test ./generator/sdk/gosdk && go vet ./generator/sdk/gosdk