Octo 11612 - #432
Open
OlteanuRares wants to merge 6 commits into
Open
Octo 11612#432OlteanuRares wants to merge 6 commits into
OlteanuRares wants to merge 6 commits into
Conversation
🟢 PR Compliance ReviewRisk Level: LOW
SAFE TO MERGE - No critical issues found Full report available in workflow artifacts |
🟢 PR Compliance ReviewRisk Level: LOW
SAFE TO MERGE - No critical issues found Full report available in workflow artifacts |
🟢 PR Compliance ReviewRisk Level: LOW
SAFE TO MERGE - No critical issues found Full report available in workflow artifacts |
🟢 PR Compliance ReviewRisk Level: LOW
SAFE TO MERGE - No critical issues found Full report available in workflow artifacts |
🟢 PR Compliance ReviewRisk Level: LOW
SAFE TO MERGE - No critical issues found Full report available in workflow artifacts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_recreate_textresolves the<p>'s region once, splits the caption's nodes into consecutive runs sharing one region, and wraps a run in<span region=...>when its region differs from the one in effect. A run that already matches takes no wrapper, so single-layout captions are untouched.Breaks are region-neutral: a run absorbs one only when it continues past it. A style tag whose partner falls outside its run still takes no wrapper, that span would cross another, but it no longer costs the text beside it a wrapper too.
Text nodes resolve through a new
RegionCreator.get_node_positioning_infothat neither cascades nor defaults, soNonemeans inherit rather than fall back to bottom._span_stackentries became(emitted, region_id), which is what lets the unwind loop close only real spans.