Conversation
5 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
asyncio.get_event_loopnow raises if there is no event loop. Work around this to maintain the same behavior as before for cases that do or or not have event loops.parameterizesyntax used in this one place here is no longer valid in the latestpytest, so fix itMotivation and Context
I'm gearing up to deploy new environments but these things were broken.
How Has This Been Tested?
The tests still pass.
Before marking this as ready for review, I will do some interactive testing to make sure a real hutch config file can still be loaded, as per the pre-merge checklist
Where Has This Been Documented?
Here only
Pre-merge checklist