Conversation
Signed-off-by: Peng Huo <penghuo@gmail.com>
Signed-off-by: Peng Huo <penghuo@gmail.com>
Signed-off-by: Peng Huo <penghuo@gmail.com>
Signed-off-by: Peng Huo <penghuo@gmail.com>
Signed-off-by: Peng Huo <penghuo@gmail.com>
Signed-off-by: Peng Huo <penghuo@gmail.com>
Signed-off-by: Peng Huo <penghuo@gmail.com>
Signed-off-by: Peng Huo <penghuo@gmail.com>
Signed-off-by: Peng Huo <penghuo@gmail.com>
Signed-off-by: Peng Huo <penghuo@gmail.com>
Signed-off-by: Peng Huo <penghuo@gmail.com>
Signed-off-by: Peng Huo <penghuo@gmail.com>
penghuo
force-pushed
the
feat/asyncquery-core
branch
from
September 24, 2026 22:44
772e356 to
7abe947
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR extracts the execution contract and lifecycle core from #7 as the first reviewable implementation slice of opensearch-project#5765. It does not register REST routes or expose the asynchronous API. Existing synchronous PPL behavior remains unchanged.
The execution module exposes one lifecycle-facing contract:
DefaultAsyncQueryExecutionadapts the existing callback execution and publishes only the final result. A successful result is visible throughcurrentResult()beforecompletion()completes normally.The lifecycle module adds:
PPLAsyncQueryJob: synchronized state machine for one query.PPLAsyncQueryService: registry, timeout race, retention, capacity, task ownership, cancellation, expiration, and cleanup.PPLAsyncQueryJobId: opaque owner-routable identifier.PPLAsyncQueryUser: retained-job owner identity.flowchart LR S[PPLAsyncQueryService] --> J[PPLAsyncQueryJob] S --> E[AsyncQueryExecution] J -->|transition| S E -->|completion| S S -->|currentResult| E S --> T[TaskManager]PPLAsyncQueryJobmutates only job-owned state while synchronized. It returns immutable transitions to the service, which performs task cancellation, registry updates, capacity accounting, listener notification, result materialization, and resource cleanup outside the job lock.PPLQueryRequestchanges, async field parsing and defaults, REST actions, owner-node transport routing, response formatting, FGAC integration tests, endpoint documentation, and plugin registration remain in the follow-up public API PR.Validation
Related Issues
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.