Conversation
Signed-off-by: Peng Huo <penghuo@gmail.com>
Signed-off-by: Peng Huo <penghuo@gmail.com>
Signed-off-by: Peng Huo <penghuo@gmail.com>
Signed-off-by: Peng Huo <penghuo@gmail.com>
Signed-off-by: Peng Huo <penghuo@gmail.com>
Signed-off-by: Peng Huo <penghuo@gmail.com>
Signed-off-by: Peng Huo <penghuo@gmail.com>
Signed-off-by: Peng Huo <penghuo@gmail.com>
Signed-off-by: Peng Huo <penghuo@gmail.com>
Signed-off-by: Peng Huo <penghuo@gmail.com>
Signed-off-by: Peng Huo <penghuo@gmail.com>
Signed-off-by: Peng Huo <penghuo@gmail.com>
Replaces PPLAsyncQueryService (~840 lines) and PPLAsyncQueryJob with a single active-object design: - QueryJob owns the state machine, retention deadline, keep-alive expiry timer, task registration and cancellation, execution attachment and completion cleanup. Public API: create(...), get(keepAlive), cancel(reason), getJobId, getOwner. Snapshot / Status / Failure are the only external types. - QueryJobRegistry is a thin ConcurrentMap wrapper with add / get / remove / close. close() calls discard() on every job and rejects further adds. - PPLAsyncQueryJobId -> QueryJobId (now public). - PPLAsyncQueryUser -> QueryJobOwner (authorize() now public). - Renamed tests keep prior coverage; PPLAsyncQueryServiceTest and PPLAsyncQueryJobTest are removed together with the service. AdmissionControl (running/retained capacity limits) and request validation are deferred to a follow-up PR, matching the current PR description's boundary. Signed-off-by: Peng Huo <penghuo@amazon.com>
…istry QueryJobTest drives one QueryJob through its lifecycle using a fake clock and a fake Scheduler. Covers direct success/failure, retention timeout, retained success/failure with metric recording, DELETE statuses, expiry via GET boundary and via expiry timer, keep-alive renewal, shutdown discard, authorization, and late-attach after DELETE. QueryJobRegistryTest covers add / remove / close semantics and the defensive jobs() snapshot. Signed-off-by: Peng Huo <penghuo@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.