Name freee's API root in the catalog - #43
Merged
Merged
Conversation
freee's API root is the same for every installation - the tenant is chosen by the token, not the URL - yet an openapi toolset on the connection was refused until the installation set connections.freee.base_url in gete.yaml, restating a value it had no say in. That shape is meant for services whose root moves with the installation; freee's does not, so the catalog now names the root itself: base_url supplies the only host and gives openapi toolsets their URLs. 🤖 Generated with Claude Code
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
freee's API root is
https://api.freee.co.jpfor every installation — the tenant is chosen by the token, not the URL. Yet an agent with anopenapi:toolset on the connection was refused bygete validateuntil the installation setconnections.freee.base_urlin itsgete.yaml, restating a value it has no say in. That shape is meant for services whose root moves with the installation (GitHub Enterprise, a Zendesk subdomain); freee's does not.What
base_url: https://api.freee.co.jpinstead of listing the host:base_urlputsapi.freee.co.jponhostsand gives openapi toolsets their root, so the entry says the same thing once.freeepassing with nothing underconnectionsingete.yaml.Installations that already set
connections.freee.base_urlkeep working: the override merges over the same value.