Conversation
Signed-off-by: Andrew Stein <steinlink@gmail.com>
Signed-off-by: Andrew Stein <steinlink@gmail.com>
Signed-off-by: Andrew Stein <steinlink@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
View::on_removecallback registration which ticks Arrow encoded IDs evicted from indexedTables. "New" because this API existed inv2.x, but did not trigger in the commonly used (but poorly performing) use case of callingTable::clearandTable::replace, followed by aTable::updatewith the same slightly modified dataset. This "new" version handles both cases correctly, and uses Arrow encoding to lessen the performance impact - however, nothing will ultimately change that this is the slowest way to use Perspective, and incremental changes viaTable::updateandTable::removeshould be preferred where possible.nulls and argument types. Casting numeric types to compare them (and having them silently fail otherwise) is no longer an issue and most types will coerce as you expect when compared, regardless of underlying type.perspective-viewerwhen text outside the component is selected and a drag/drop operation is attempted.