Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/Type/Pest/HigherOrderExpectationTypeExtension.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
use PhpParser\Node\Expr\PropertyFetch;
use PhpParser\Node\Identifier;
use PHPStan\Analyser\Scope;
use PHPStan\Reflection\MissingPropertyFromReflectionException;
use PHPStan\Reflection\ReflectionProvider;
use PHPStan\Type\ExpressionTypeResolverExtension;
use PHPStan\Type\Generic\GenericObjectType;
Expand Down Expand Up @@ -187,7 +188,11 @@ private function resolvePropertyType(Type $objectType, string $propertyName, Sco
return null;
}

return $objectType->getProperty($propertyName, $scope)->getReadableType();
try {
return $objectType->getProperty($propertyName, $scope)->getReadableType();
} catch (MissingPropertyFromReflectionException) {
return new MixedType;
}
}

private function isNativeExpectationProperty(string $propertyName): bool
Expand Down
13 changes: 13 additions & 0 deletions tests/Type/Fixtures/MagicPropertyObject.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<?php

declare(strict_types=1);

namespace Tests\Type\Fixtures;

final class MagicPropertyObject
{
public function __get(string $name): mixed
{
return null;
}
}
23 changes: 23 additions & 0 deletions tests/Type/data/higher-order-expectations.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

namespace HigherOrderExpectations;

use Tests\Type\Fixtures\MagicPropertyObject;
use Tests\Type\Fixtures\Post;

use function PHPStan\Testing\assertType;
Expand Down Expand Up @@ -107,3 +108,25 @@ function testPropertyChainAfterAssertionReset(): void
->author;
assertType('Pest\Expectations\HigherOrderExpectation<Pest\Expectation<Tests\Type\Fixtures\Post>, Tests\Type\Fixtures\Author>', $result);
}

function testMagicPropertyDoesNotCrash(): void
{
$object = new MagicPropertyObject;
$result = expect($object)->name;
assertType('Pest\Expectations\HigherOrderExpectation<Pest\Expectation<Tests\Type\Fixtures\MagicPropertyObject>, mixed>', $result);
}

function testMagicPropertyChainDoesNotCrash(): void
{
$object = new MagicPropertyObject;
$result = expect($object)->name->toBe('Nuno');
assertType('Pest\Expectations\HigherOrderExpectation<Pest\Expectation<Tests\Type\Fixtures\MagicPropertyObject>, Tests\Type\Fixtures\MagicPropertyObject>', $result);
}

function testUnionWithoutClassPropertyDoesNotCrash(): void
{
/** @var array<string, mixed>|object|null $payload */
$payload = null;
$result = expect($payload)->currentUser;
assertType('Pest\Expectations\HigherOrderExpectation<Pest\Expectation<array<string, mixed>|object|null>, mixed>', $result);
}