ci: add an all-tests-passed aggregator job - #28
Merged
Conversation
Branch protection needs a single, stable required-check name to gate merges on. Requiring all 12 individual `test (os, python-version)` matrix legs directly is brittle -- adding/removing a matrix entry silently changes what's enforced without anyone updating branch protection settings. This job depends on the whole matrix and fails loudly (rather than relying on ambiguous "skipped" semantics) if any leg didn't succeed, giving one check name to require instead. Not touching branch protection itself here -- that's a repo-settings change, done separately once this merges and has run at least once.
Up to standards ✅🟢 Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All tests passedjob that depends on the fulltestmatrix (12 legs: 3 OS × 4 Python versions) and fails loudly if any leg didn't succeed.testandcodecovjobs untouched.Test plan
All tests passedin the checks list below