Repository navigation
Conversation
Chunk building stripped each section/paragraph with str.strip(), which removed the leading indentation of the first line of a 4-space indented code block. That re-flowed the code in the stored chunk and again when the chunk was injected into an AI prompt. Trim surrounding blank lines instead, preserving interior indentation.
Owner
|
Approved — this is a necessary correctness fix. Chunk construction and prompt-context generation now preserve the leading indentation required for indented Markdown code blocks, preventing code from being reflowed as prose. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Chunk building trimmed each section/paragraph with
str.strip(), which removes the leading indentation of the first line of a 4-space indented code block:The stored chunk and the AI prompt context both re-flowed the code as though the indentation never existed.
Fix
Trim surrounding blank lines instead of all whitespace (
strip("\n").rstrip()), preserving interior indentation — in the section path, the paragraph-split path (large sections), and the prompt-context builder.Tests
tests/test_knowledge_logic.py: the first code line keeps its indent in the small-section path, the large-section (paragraph-split) path, and the prompt context.