fix(skill): keep generated instructions runnable

[andrebrait]

Summary

• quote POSIX and PowerShell scan-root placeholders in generated instructions
• preserve the recorded scan root when adding a watch
• remove a duplicate import and an unsupported export example
• regenerate every affected platform skill and snapshot

Verification

• uv run pytest tests/test_skillgen.py — 66 passed
• uv run python -m tools.skillgen --check — 134 artifacts match
• frozen regression-test hash: 37d83962a9e39641fcdc1a52b0312300904cb042
• the frozen test fails at parent 23a2a2a on the unquoted PowerShell path and passes unchanged at 61a0b68

Supports pfBlockerNG/pfBlockerNG#3267.

[andrebrait]

@coderabbitai review

[Copilot]

🟢 Approval recommended

Changes are consistent across fragments, regenerated artifacts, and tests, and the new regression test directly protects the intended runnable-instructions behavior.

Pull request overview

This PR updates the skill generator and regenerated skill artifacts to ensure the generated “runbook” instructions remain runnable and consistently reuse the previously recorded scan root (particularly across follow-up operations like add/watch and update).

Changes:

• Quote the scan-root placeholder in the POSIX shell fragment when persisting graphify-out/.graphify_root.
• Update “add-watch” guidance to run the --update pipeline using the scan root recorded in graphify-out/.graphify_root.
• Remove a duplicate import json and drop an unsupported graphify export html --no-viz example; regenerate affected expected outputs and add a regression test.

File summaries

File	Description
tools/skillgen/fragments/shell/posix.md	Quotes INPUT_PATH in the POSIX snippet that records the scan root, improving runnability for paths with spaces.
tools/skillgen/fragments/references/shared/add-watch.md	Updates add-watch guidance to use the recorded scan root for the --update pipeline.
tools/skillgen/fragments/core/core.md	Removes a duplicate import json and deletes an unsupported --no-viz export example.
tools/skillgen/expected/graphify__skills__windows__references__add-watch.md	Regenerated expected Windows add-watch reference to match updated guidance.
tools/skillgen/expected/graphify__skills__vscode__references__add-watch.md	Regenerated expected VS Code add-watch reference to match updated guidance.
tools/skillgen/expected/graphify__skills__trae__references__add-watch.md	Regenerated expected Trae add-watch reference to match updated guidance.
tools/skillgen/expected/graphify__skills__pi__references__add-watch.md	Regenerated expected Pi add-watch reference to match updated guidance.
tools/skillgen/expected/graphify__skills__opencode__references__add-watch.md	Regenerated expected OpenCode add-watch reference to match updated guidance.
tools/skillgen/expected/graphify__skills__kiro__references__add-watch.md	Regenerated expected Kiro add-watch reference to match updated guidance.
tools/skillgen/expected/graphify__skills__kilo__references__add-watch.md	Regenerated expected Kilo add-watch reference to match updated guidance.
tools/skillgen/expected/graphify__skills__droid__references__add-watch.md	Regenerated expected Droid add-watch reference to match updated guidance.
tools/skillgen/expected/graphify__skills__copilot__references__add-watch.md	Regenerated expected Copilot add-watch reference to match updated guidance.
tools/skillgen/expected/graphify__skills__codex__references__add-watch.md	Regenerated expected Codex add-watch reference to match updated guidance.
tools/skillgen/expected/graphify__skills__claw__references__add-watch.md	Regenerated expected Claw add-watch reference to match updated guidance.
tools/skillgen/expected/graphify__skills__claude__references__add-watch.md	Regenerated expected Claude add-watch reference to match updated guidance.
tools/skillgen/expected/graphify__skills__amp__references__add-watch.md	Regenerated expected Amp add-watch reference to match updated guidance.
tools/skillgen/expected/graphify__skills__agents__references__add-watch.md	Regenerated expected Agents add-watch reference to match updated guidance.
tools/skillgen/expected/graphify__skill.md	Regenerated expected core skill output to reflect POSIX quoting + removed duplicate import + removed unsupported export example.
tools/skillgen/expected/graphify__skill-windows.md	Regenerated expected Windows core skill output to reflect removed duplicate import + removed unsupported export example.
tools/skillgen/expected/graphify__skill-vscode.md	Regenerated expected VS Code core skill output to reflect POSIX quoting + removed duplicate import + removed unsupported export example.
tools/skillgen/expected/graphify__skill-trae.md	Regenerated expected Trae core skill output to reflect POSIX quoting + removed duplicate import + removed unsupported export example.
tools/skillgen/expected/graphify__skill-pi.md	Regenerated expected Pi core skill output to reflect POSIX quoting + removed duplicate import + removed unsupported export example.
tools/skillgen/expected/graphify__skill-opencode.md	Regenerated expected OpenCode core skill output to reflect POSIX quoting + removed duplicate import + removed unsupported export example.
tools/skillgen/expected/graphify__skill-kiro.md	Regenerated expected Kiro core skill output to reflect POSIX quoting + removed duplicate import + removed unsupported export example.
tools/skillgen/expected/graphify__skill-kilo.md	Regenerated expected Kilo core skill output to reflect POSIX quoting + removed duplicate import + removed unsupported export example.
tools/skillgen/expected/graphify__skill-droid.md	Regenerated expected Droid core skill output to reflect POSIX quoting + removed duplicate import + removed unsupported export example.
tools/skillgen/expected/graphify__skill-copilot.md	Regenerated expected Copilot core skill output to reflect POSIX quoting + removed duplicate import + removed unsupported export example.
tools/skillgen/expected/graphify__skill-codex.md	Regenerated expected Codex core skill output to reflect POSIX quoting + removed duplicate import + removed unsupported export example.
tools/skillgen/expected/graphify__skill-claw.md	Regenerated expected Claw core skill output to reflect POSIX quoting + removed duplicate import + removed unsupported export example.
tools/skillgen/expected/graphify__skill-amp.md	Regenerated expected Amp core skill output to reflect POSIX quoting + removed duplicate import + removed unsupported export example.
tools/skillgen/expected/graphify__skill-agents.md	Regenerated expected Agents core skill output to reflect POSIX quoting + removed duplicate import + removed unsupported export example.
tests/test_skillgen.py	Adds a regression test to assert key instruction/runbook invariants in rendered artifacts.
graphify/skills/windows/references/add-watch.md	Updates shipped Windows add-watch reference guidance to use recorded scan root for --update.
graphify/skills/vscode/references/add-watch.md	Updates shipped VS Code add-watch reference guidance to use recorded scan root for --update.
graphify/skills/trae/references/add-watch.md	Updates shipped Trae add-watch reference guidance to use recorded scan root for --update.
graphify/skills/pi/references/add-watch.md	Updates shipped Pi add-watch reference guidance to use recorded scan root for --update.
graphify/skills/opencode/references/add-watch.md	Updates shipped OpenCode add-watch reference guidance to use recorded scan root for --update.
graphify/skills/kiro/references/add-watch.md	Updates shipped Kiro add-watch reference guidance to use recorded scan root for --update.
graphify/skills/kilo/references/add-watch.md	Updates shipped Kilo add-watch reference guidance to use recorded scan root for --update.
graphify/skills/droid/references/add-watch.md	Updates shipped Droid add-watch reference guidance to use recorded scan root for --update.
graphify/skills/copilot/references/add-watch.md	Updates shipped Copilot add-watch reference guidance to use recorded scan root for --update.
graphify/skills/codex/references/add-watch.md	Updates shipped Codex add-watch reference guidance to use recorded scan root for --update.
graphify/skills/claw/references/add-watch.md	Updates shipped Claw add-watch reference guidance to use recorded scan root for --update.
graphify/skills/claude/references/add-watch.md	Updates shipped Claude add-watch reference guidance to use recorded scan root for --update.
graphify/skills/amp/references/add-watch.md	Updates shipped Amp add-watch reference guidance to use recorded scan root for --update.
graphify/skills/agents/references/add-watch.md	Updates shipped Agents add-watch reference guidance to use recorded scan root for --update.
graphify/skill.md	Regenerated primary shipped skill to include POSIX quoting + remove duplicate import + remove unsupported export example.
graphify/skill-windows.md	Regenerated shipped Windows skill to remove duplicate import + remove unsupported export example.
graphify/skill-vscode.md	Regenerated shipped VS Code skill to include POSIX quoting + remove duplicate import + remove unsupported export example.
graphify/skill-trae.md	Regenerated shipped Trae skill to include POSIX quoting + remove duplicate import + remove unsupported export example.
graphify/skill-pi.md	Regenerated shipped Pi skill to include POSIX quoting + remove duplicate import + remove unsupported export example.
graphify/skill-opencode.md	Regenerated shipped OpenCode skill to include POSIX quoting + remove duplicate import + remove unsupported export example.
graphify/skill-kiro.md	Regenerated shipped Kiro skill to include POSIX quoting + remove duplicate import + remove unsupported export example.
graphify/skill-kilo.md	Regenerated shipped Kilo skill to include POSIX quoting + remove duplicate import + remove unsupported export example.
graphify/skill-droid.md	Regenerated shipped Droid skill to include POSIX quoting + remove duplicate import + remove unsupported export example.
graphify/skill-copilot.md	Regenerated shipped Copilot skill to include POSIX quoting + remove duplicate import + remove unsupported export example.
graphify/skill-codex.md	Regenerated shipped Codex skill to include POSIX quoting + remove duplicate import + remove unsupported export example.
graphify/skill-claw.md	Regenerated shipped Claw skill to include POSIX quoting + remove duplicate import + remove unsupported export example.
graphify/skill-amp.md	Regenerated shipped Amp skill to include POSIX quoting + remove duplicate import + remove unsupported export example.
graphify/skill-agents.md	Regenerated shipped Agents skill to include POSIX quoting + remove duplicate import + remove unsupported export example.

Review details

• Files reviewed: 60/60 changed files
• Comments generated: 0
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🟢 Approval recommended

The changes are consistent across fragments, regenerated artifacts, and snapshots, and the added regression test covers the intended instruction invariants.

Review details

Suppressed comments (1)

Previously missed (1) — in code that hasn't changed since the last review.

tests/test_skillgen.py:78

• The duplicate-import regression check is currently implemented as an exact multi-line substring match. This can miss a reintroduced import json if formatting changes slightly (e.g., an extra blank line or different spacing) while still leaving the duplicate import in place.

Consider asserting structurally around the extraction import marker (find the from graphify.extract ... line and ensure the next few lines do not contain a standalone import json). This keeps the test focused on the extraction snippet without being dependent on an exact 4-line block match.

• Files reviewed: 61/61 changed files
• Comments generated: 0 new
• Review effort level: Lite