fix(skill): correct generated safety guidance - #2
Merged
andrebrait merged 2 commits intoSep 10, 2026
Merged
andrebrait merged 2 commits into
andrebrait merged 2 commits into
Conversation
Member
Author
|
@coderabbitai review |
Member
Author
|
@coderabbitai review |
andrebrait
merged commit Sep 10, 2026
bdd5d33
into
issue/3254-refresh-graphify-fork-0.9.57
1 check passed
There was a problem hiding this comment.
🟡 Changes recommended
The updated Neo4j export guidance removes --password but doesn’t include a concrete example of how to set NEO4J_PASSWORD securely, making the instructions incomplete/ambiguous for users.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the skill generator’s “safety guidance” and regenerated skill artifacts to match current runtime behavior and to keep examples secure and machine-parseable.
Changes:
- Added a sanctioned-diff predicate so monolith roundtrips tolerate the cleanup command targeting
graphify-out/needs_update(no leading dot). - Updated extraction schema examples to use full-path-based node IDs and ensured JSON examples remain valid JSON.
- Updated Neo4j export guidance to avoid passing passwords via command-line args, relying on
NEO4J_PASSWORD, and regenerated affected skill snapshots/expected outputs.
File summaries
| File | Description |
|---|---|
| tools/skillgen/gen.py | Allows monolith roundtrip diffs for needs_update cleanup line changes. |
| tools/skillgen/fragments/references/shared/extraction-spec.md | Updates extraction JSON example to use full-path node IDs. |
| tools/skillgen/fragments/references/shared/extraction-spec-compact.md | Updates compact extraction JSON example to use full-path node IDs. |
| tools/skillgen/fragments/references/shared/exports.md | Updates Neo4j push guidance to avoid --password on argv. |
| tools/skillgen/fragments/core/devin.md | Updates cleanup command to remove graphify-out/needs_update. |
| tools/skillgen/fragments/core/core.md | Updates cleanup command to remove graphify-out/needs_update. |
| tools/skillgen/fragments/core/aider.md | Updates cleanup command to remove graphify-out/needs_update. |
| tools/skillgen/expected/graphify__skills__windows__references__extraction-spec.md | Regenerated expected Windows extraction spec with updated node ID example. |
| tools/skillgen/expected/graphify__skills__windows__references__exports.md | Regenerated expected Windows exports guidance without --password. |
| tools/skillgen/expected/graphify__skills__vscode__references__extraction-spec.md | Regenerated expected VS Code extraction spec with updated node ID example. |
| tools/skillgen/expected/graphify__skills__vscode__references__exports.md | Regenerated expected VS Code exports guidance without --password. |
| tools/skillgen/expected/graphify__skills__trae__references__extraction-spec.md | Regenerated expected Trae extraction spec with updated node ID example. |
| tools/skillgen/expected/graphify__skills__trae__references__exports.md | Regenerated expected Trae exports guidance without --password. |
| tools/skillgen/expected/graphify__skills__pi__references__extraction-spec.md | Regenerated expected Pi extraction spec with updated node ID example. |
| tools/skillgen/expected/graphify__skills__pi__references__exports.md | Regenerated expected Pi exports guidance without --password. |
| tools/skillgen/expected/graphify__skills__opencode__references__extraction-spec.md | Regenerated expected OpenCode extraction spec with updated node ID example. |
| tools/skillgen/expected/graphify__skills__opencode__references__exports.md | Regenerated expected OpenCode exports guidance without --password. |
| tools/skillgen/expected/graphify__skills__kiro__references__extraction-spec.md | Regenerated expected Kiro extraction spec with updated node ID example. |
| tools/skillgen/expected/graphify__skills__kiro__references__exports.md | Regenerated expected Kiro exports guidance without --password. |
| tools/skillgen/expected/graphify__skills__kilo__references__extraction-spec.md | Regenerated expected Kilo extraction spec with updated node ID example. |
| tools/skillgen/expected/graphify__skills__kilo__references__exports.md | Regenerated expected Kilo exports guidance without --password. |
| tools/skillgen/expected/graphify__skills__droid__references__extraction-spec.md | Regenerated expected Droid extraction spec with updated node ID example. |
| tools/skillgen/expected/graphify__skills__droid__references__exports.md | Regenerated expected Droid exports guidance without --password. |
| tools/skillgen/expected/graphify__skills__copilot__references__extraction-spec.md | Regenerated expected Copilot extraction spec with updated node ID example. |
| tools/skillgen/expected/graphify__skills__copilot__references__exports.md | Regenerated expected Copilot exports guidance without --password. |
| tools/skillgen/expected/graphify__skills__codex__references__extraction-spec.md | Regenerated expected Codex extraction spec with updated node ID example. |
| tools/skillgen/expected/graphify__skills__codex__references__exports.md | Regenerated expected Codex exports guidance without --password. |
| tools/skillgen/expected/graphify__skills__claw__references__extraction-spec.md | Regenerated expected Claw extraction spec with updated node ID example. |
| tools/skillgen/expected/graphify__skills__claw__references__exports.md | Regenerated expected Claw exports guidance without --password. |
| tools/skillgen/expected/graphify__skills__claude__references__extraction-spec.md | Regenerated expected Claude extraction spec with updated node ID example. |
| tools/skillgen/expected/graphify__skills__claude__references__exports.md | Regenerated expected Claude exports guidance without --password. |
| tools/skillgen/expected/graphify__skills__amp__references__extraction-spec.md | Regenerated expected Amp extraction spec with updated node ID example. |
| tools/skillgen/expected/graphify__skills__amp__references__exports.md | Regenerated expected Amp exports guidance without --password. |
| tools/skillgen/expected/graphify__skills__agents__references__extraction-spec.md | Regenerated expected Agents extraction spec with updated node ID example. |
| tools/skillgen/expected/graphify__skills__agents__references__exports.md | Regenerated expected Agents exports guidance without --password. |
| tools/skillgen/expected/graphify__skill.md | Regenerated top-level skill doc cleanup to remove graphify-out/needs_update. |
| tools/skillgen/expected/graphify__skill-windows.md | Regenerated Windows skill doc cleanup to remove graphify-out\\needs_update. |
| tools/skillgen/expected/graphify__skill-vscode.md | Regenerated VS Code skill doc cleanup to remove graphify-out/needs_update. |
| tools/skillgen/expected/graphify__skill-trae.md | Regenerated Trae skill doc cleanup to remove graphify-out/needs_update. |
| tools/skillgen/expected/graphify__skill-pi.md | Regenerated Pi skill doc cleanup to remove graphify-out/needs_update. |
| tools/skillgen/expected/graphify__skill-opencode.md | Regenerated OpenCode skill doc cleanup to remove graphify-out/needs_update. |
| tools/skillgen/expected/graphify__skill-kiro.md | Regenerated Kiro skill doc cleanup to remove graphify-out/needs_update. |
| tools/skillgen/expected/graphify__skill-kilo.md | Regenerated Kilo skill doc cleanup to remove graphify-out/needs_update. |
| tools/skillgen/expected/graphify__skill-droid.md | Regenerated Droid skill doc cleanup to remove graphify-out/needs_update. |
| tools/skillgen/expected/graphify__skill-devin.md | Regenerated Devin skill doc cleanup to remove graphify-out/needs_update. |
| tools/skillgen/expected/graphify__skill-copilot.md | Regenerated Copilot skill doc cleanup to remove graphify-out/needs_update. |
| tools/skillgen/expected/graphify__skill-codex.md | Regenerated Codex skill doc cleanup to remove graphify-out/needs_update. |
| tools/skillgen/expected/graphify__skill-claw.md | Regenerated Claw skill doc cleanup to remove graphify-out/needs_update. |
| tools/skillgen/expected/graphify__skill-amp.md | Regenerated Amp skill doc cleanup to remove graphify-out/needs_update. |
| tools/skillgen/expected/graphify__skill-aider.md | Regenerated Aider skill doc cleanup to remove graphify-out/needs_update. |
| tools/skillgen/expected/graphify__skill-agents.md | Regenerated Agents skill doc cleanup to remove graphify-out/needs_update. |
| tests/test_skillgen.py | Adds regression checks for updated examples (JSON validity, no --password, no .needs_update, no old node ID example). |
| graphify/skills/windows/references/extraction-spec.md | Updates Windows extraction spec to use full-path node ID in JSON example. |
| graphify/skills/windows/references/exports.md | Updates Windows exports guidance to avoid --password on argv. |
| graphify/skills/vscode/references/extraction-spec.md | Updates VS Code extraction spec to use full-path node ID in JSON example. |
| graphify/skills/vscode/references/exports.md | Updates VS Code exports guidance to avoid --password on argv. |
| graphify/skills/trae/references/extraction-spec.md | Updates Trae extraction spec to use full-path node ID in JSON example. |
| graphify/skills/trae/references/exports.md | Updates Trae exports guidance to avoid --password on argv. |
| graphify/skills/pi/references/extraction-spec.md | Updates Pi extraction spec to use full-path node ID in JSON example. |
| graphify/skills/pi/references/exports.md | Updates Pi exports guidance to avoid --password on argv. |
| graphify/skills/opencode/references/extraction-spec.md | Updates OpenCode extraction spec to use full-path node ID in JSON example. |
| graphify/skills/opencode/references/exports.md | Updates OpenCode exports guidance to avoid --password on argv. |
| graphify/skills/kiro/references/extraction-spec.md | Updates Kiro extraction spec to use full-path node ID in JSON example. |
| graphify/skills/kiro/references/exports.md | Updates Kiro exports guidance to avoid --password on argv. |
| graphify/skills/kilo/references/extraction-spec.md | Updates Kilo extraction spec to use full-path node ID in JSON example. |
| graphify/skills/kilo/references/exports.md | Updates Kilo exports guidance to avoid --password on argv. |
| graphify/skills/droid/references/extraction-spec.md | Updates Droid extraction spec to use full-path node ID in JSON example. |
| graphify/skills/droid/references/exports.md | Updates Droid exports guidance to avoid --password on argv. |
| graphify/skills/copilot/references/extraction-spec.md | Updates Copilot extraction spec to use full-path node ID in JSON example. |
| graphify/skills/copilot/references/exports.md | Updates Copilot exports guidance to avoid --password on argv. |
| graphify/skills/codex/references/extraction-spec.md | Updates Codex extraction spec to use full-path node ID in JSON example. |
| graphify/skills/codex/references/exports.md | Updates Codex exports guidance to avoid --password on argv. |
| graphify/skills/claw/references/extraction-spec.md | Updates Claw extraction spec to use full-path node ID in JSON example. |
| graphify/skills/claw/references/exports.md | Updates Claw exports guidance to avoid --password on argv. |
| graphify/skills/claude/references/extraction-spec.md | Updates Claude extraction spec to use full-path node ID in JSON example. |
| graphify/skills/claude/references/exports.md | Updates Claude exports guidance to avoid --password on argv. |
| graphify/skills/amp/references/extraction-spec.md | Updates Amp extraction spec to use full-path node ID in JSON example. |
| graphify/skills/amp/references/exports.md | Updates Amp exports guidance to avoid --password on argv. |
| graphify/skills/agents/references/extraction-spec.md | Updates Agents extraction spec to use full-path node ID in JSON example. |
| graphify/skills/agents/references/exports.md | Updates Agents exports guidance to avoid --password on argv. |
| graphify/skill.md | Updates cleanup command to remove graphify-out/needs_update. |
| graphify/skill-windows.md | Updates cleanup command to remove graphify-out\\needs_update. |
| graphify/skill-vscode.md | Updates cleanup command to remove graphify-out/needs_update. |
| graphify/skill-trae.md | Updates cleanup command to remove graphify-out/needs_update. |
| graphify/skill-pi.md | Updates cleanup command to remove graphify-out/needs_update. |
| graphify/skill-opencode.md | Updates cleanup command to remove graphify-out/needs_update. |
| graphify/skill-kiro.md | Updates cleanup command to remove graphify-out/needs_update. |
| graphify/skill-kilo.md | Updates cleanup command to remove graphify-out/needs_update. |
| graphify/skill-droid.md | Updates cleanup command to remove graphify-out/needs_update. |
| graphify/skill-devin.md | Updates cleanup command to remove graphify-out/needs_update. |
| graphify/skill-copilot.md | Updates cleanup command to remove graphify-out/needs_update. |
| graphify/skill-codex.md | Updates cleanup command to remove graphify-out/needs_update. |
| graphify/skill-claw.md | Updates cleanup command to remove graphify-out/needs_update. |
| graphify/skill-amp.md | Updates cleanup command to remove graphify-out/needs_update. |
| graphify/skill-aider.md | Updates cleanup command to remove graphify-out/needs_update. |
| graphify/skill-agents.md | Updates cleanup command to remove graphify-out/needs_update. |
Review details
- Files reviewed: 96/96 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+23
to
27
| **If `--neo4j-push <uri>`** - push directly to a running Neo4j instance. Ask the user for credentials if not provided. Put the password in `NEO4J_PASSWORD` without exposing it in shell history or command arguments: | ||
|
|
||
| ```bash | ||
| graphify export neo4j --push bolt://localhost:7687 --user neo4j --password PASSWORD | ||
| graphify export neo4j --push bolt://localhost:7687 --user neo4j | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
needs_updateflagVerification
uv run pytest tests/test_skillgen.py— 66 passeduv run python -m tools.skillgen --check— 134 artifacts matchb8925811cff10ebc0f577839ad5c93f312145cbe31b90c2on the invalid schema JSON and passes unchanged atbdd5d33Supports pfBlockerNG/pfBlockerNG#3267.