fix(skill): show safe Neo4j credential setup - #3
Merged
andrebrait merged 3 commits intoSep 10, 2026
Merged
andrebrait merged 3 commits into
andrebrait merged 3 commits into
Conversation
Member
Author
|
@coderabbitai review |
Member
Author
|
@coderabbitai review |
andrebrait
merged commit Sep 10, 2026
dc4d53b
into
issue/3254-refresh-graphify-fork-0.9.57
1 check passed
There was a problem hiding this comment.
🟢 Approval recommended
The changes are consistent across fragments and regenerated artifacts, and the added tests enforce the intended safety/abort behavior.
Pull request overview
This PR updates the generated “skill” documentation and supporting skillgen fixtures to (1) demonstrate safer Neo4j password entry (hidden-input, no chat pasting) and (2) ensure Step 5 aborts immediately if the graph.json shrink-guard refuses to write, preventing downstream report/label sidecar writes for a graph that wasn’t persisted.
Changes:
- Update Neo4j push instructions to require user-run interactive terminal commands and provide hidden-input password setup for POSIX shells and PowerShell.
- Change Step 5 labeling flow to
raise SystemExit(1)on shrink-guard refusal before writingGRAPH_REPORT.md/ labels sidecars. - Regenerate all affected skill artifacts/snapshots and add regression assertions in
tests/test_skillgen.py.
File summaries
| File | Description |
|---|---|
| tools/skillgen/fragments/references/shared/exports.md | Updates shared exports reference text with interactive hidden-password Neo4j push instructions (POSIX + PowerShell). |
| tools/skillgen/fragments/core/devin.md | Ensures Step 5 aborts on shrink-guard refusal before writing report/labels. |
| tools/skillgen/fragments/core/core.md | Ensures Step 5 aborts on shrink-guard refusal before writing report/labels (core template). |
| tools/skillgen/fragments/core/aider.md | Ensures Step 5 aborts on shrink-guard refusal before writing report/labels. |
| tools/skillgen/expected/graphify__skills__windows__references__exports.md | Regenerated expected Windows exports reference artifact reflecting new Neo4j credential guidance. |
| tools/skillgen/expected/graphify__skills__vscode__references__exports.md | Regenerated expected VS Code exports reference artifact reflecting new Neo4j credential guidance. |
| tools/skillgen/expected/graphify__skills__trae__references__exports.md | Regenerated expected Trae exports reference artifact reflecting new Neo4j credential guidance. |
| tools/skillgen/expected/graphify__skills__pi__references__exports.md | Regenerated expected Pi exports reference artifact reflecting new Neo4j credential guidance. |
| tools/skillgen/expected/graphify__skills__opencode__references__exports.md | Regenerated expected OpenCode exports reference artifact reflecting new Neo4j credential guidance. |
| tools/skillgen/expected/graphify__skills__kiro__references__exports.md | Regenerated expected Kiro exports reference artifact reflecting new Neo4j credential guidance. |
| tools/skillgen/expected/graphify__skills__kilo__references__exports.md | Regenerated expected Kilo exports reference artifact reflecting new Neo4j credential guidance. |
| tools/skillgen/expected/graphify__skills__droid__references__exports.md | Regenerated expected Droid exports reference artifact reflecting new Neo4j credential guidance. |
| tools/skillgen/expected/graphify__skills__copilot__references__exports.md | Regenerated expected Copilot exports reference artifact reflecting new Neo4j credential guidance. |
| tools/skillgen/expected/graphify__skills__codex__references__exports.md | Regenerated expected Codex exports reference artifact reflecting new Neo4j credential guidance. |
| tools/skillgen/expected/graphify__skills__claw__references__exports.md | Regenerated expected Claw exports reference artifact reflecting new Neo4j credential guidance. |
| tools/skillgen/expected/graphify__skills__claude__references__exports.md | Regenerated expected Claude exports reference artifact reflecting new Neo4j credential guidance. |
| tools/skillgen/expected/graphify__skills__amp__references__exports.md | Regenerated expected Amp exports reference artifact reflecting new Neo4j credential guidance. |
| tools/skillgen/expected/graphify__skills__agents__references__exports.md | Regenerated expected Agents exports reference artifact reflecting new Neo4j credential guidance. |
| tools/skillgen/expected/graphify__skill.md | Regenerated expected main skill doc reflecting Step 5 abort semantics. |
| tools/skillgen/expected/graphify__skill-windows.md | Regenerated expected Windows skill doc reflecting Step 5 abort semantics. |
| tools/skillgen/expected/graphify__skill-vscode.md | Regenerated expected VS Code skill doc reflecting Step 5 abort semantics. |
| tools/skillgen/expected/graphify__skill-trae.md | Regenerated expected Trae skill doc reflecting Step 5 abort semantics. |
| tools/skillgen/expected/graphify__skill-pi.md | Regenerated expected Pi skill doc reflecting Step 5 abort semantics. |
| tools/skillgen/expected/graphify__skill-opencode.md | Regenerated expected OpenCode skill doc reflecting Step 5 abort semantics. |
| tools/skillgen/expected/graphify__skill-kiro.md | Regenerated expected Kiro skill doc reflecting Step 5 abort semantics. |
| tools/skillgen/expected/graphify__skill-kilo.md | Regenerated expected Kilo skill doc reflecting Step 5 abort semantics. |
| tools/skillgen/expected/graphify__skill-droid.md | Regenerated expected Droid skill doc reflecting Step 5 abort semantics. |
| tools/skillgen/expected/graphify__skill-devin.md | Regenerated expected Devin skill doc reflecting Step 5 abort semantics. |
| tools/skillgen/expected/graphify__skill-copilot.md | Regenerated expected Copilot skill doc reflecting Step 5 abort semantics. |
| tools/skillgen/expected/graphify__skill-codex.md | Regenerated expected Codex skill doc reflecting Step 5 abort semantics. |
| tools/skillgen/expected/graphify__skill-claw.md | Regenerated expected Claw skill doc reflecting Step 5 abort semantics. |
| tools/skillgen/expected/graphify__skill-amp.md | Regenerated expected Amp skill doc reflecting Step 5 abort semantics. |
| tools/skillgen/expected/graphify__skill-aider.md | Regenerated expected Aider skill doc reflecting Step 5 abort semantics. |
| tools/skillgen/expected/graphify__skill-agents.md | Regenerated expected Agents skill doc reflecting Step 5 abort semantics. |
| tests/test_skillgen.py | Adds assertions ensuring exports docs include safe credential prompts and Step 5 abort ordering is preserved. |
| graphify/skills/windows/references/exports.md | Updates the Windows skill’s exports reference page with safe Neo4j password handling guidance. |
| graphify/skills/vscode/references/exports.md | Updates the VS Code skill’s exports reference page with safe Neo4j password handling guidance. |
| graphify/skills/trae/references/exports.md | Updates the Trae skill’s exports reference page with safe Neo4j password handling guidance. |
| graphify/skills/pi/references/exports.md | Updates the Pi skill’s exports reference page with safe Neo4j password handling guidance. |
| graphify/skills/opencode/references/exports.md | Updates the OpenCode skill’s exports reference page with safe Neo4j password handling guidance. |
| graphify/skills/kiro/references/exports.md | Updates the Kiro skill’s exports reference page with safe Neo4j password handling guidance. |
| graphify/skills/kilo/references/exports.md | Updates the Kilo skill’s exports reference page with safe Neo4j password handling guidance. |
| graphify/skills/droid/references/exports.md | Updates the Droid skill’s exports reference page with safe Neo4j password handling guidance. |
| graphify/skills/copilot/references/exports.md | Updates the Copilot skill’s exports reference page with safe Neo4j password handling guidance. |
| graphify/skills/codex/references/exports.md | Updates the Codex skill’s exports reference page with safe Neo4j password handling guidance. |
| graphify/skills/claw/references/exports.md | Updates the Claw skill’s exports reference page with safe Neo4j password handling guidance. |
| graphify/skills/claude/references/exports.md | Updates the Claude skill’s exports reference page with safe Neo4j password handling guidance. |
| graphify/skills/amp/references/exports.md | Updates the Amp skill’s exports reference page with safe Neo4j password handling guidance. |
| graphify/skills/agents/references/exports.md | Updates the Agents skill’s exports reference page with safe Neo4j password handling guidance. |
| graphify/skill.md | Updates the main skill doc to abort Step 5 on shrink-guard refusal before writing report/labels. |
| graphify/skill-windows.md | Updates the Windows skill doc to abort Step 5 on shrink-guard refusal before writing report/labels. |
| graphify/skill-vscode.md | Updates the VS Code skill doc to abort Step 5 on shrink-guard refusal before writing report/labels. |
| graphify/skill-trae.md | Updates the Trae skill doc to abort Step 5 on shrink-guard refusal before writing report/labels. |
| graphify/skill-pi.md | Updates the Pi skill doc to abort Step 5 on shrink-guard refusal before writing report/labels. |
| graphify/skill-opencode.md | Updates the OpenCode skill doc to abort Step 5 on shrink-guard refusal before writing report/labels. |
| graphify/skill-kiro.md | Updates the Kiro skill doc to abort Step 5 on shrink-guard refusal before writing report/labels. |
| graphify/skill-kilo.md | Updates the Kilo skill doc to abort Step 5 on shrink-guard refusal before writing report/labels. |
| graphify/skill-droid.md | Updates the Droid skill doc to abort Step 5 on shrink-guard refusal before writing report/labels. |
| graphify/skill-devin.md | Updates the Devin skill doc to abort Step 5 on shrink-guard refusal before writing report/labels. |
| graphify/skill-copilot.md | Updates the Copilot skill doc to abort Step 5 on shrink-guard refusal before writing report/labels. |
| graphify/skill-codex.md | Updates the Codex skill doc to abort Step 5 on shrink-guard refusal before writing report/labels. |
| graphify/skill-claw.md | Updates the Claw skill doc to abort Step 5 on shrink-guard refusal before writing report/labels. |
| graphify/skill-amp.md | Updates the Amp skill doc to abort Step 5 on shrink-guard refusal before writing report/labels. |
| graphify/skill-aider.md | Updates the Aider skill doc to abort Step 5 on shrink-guard refusal before writing report/labels. |
| graphify/skill-agents.md | Updates the Agents skill doc to abort Step 5 on shrink-guard refusal before writing report/labels. |
Review details
- Files reviewed: 65/65 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
uv run pytest tests/test_skillgen.py— 66 passeduv run python -m tools.skillgen --check— 134 artifacts match6124f54a9c6db944c7e72591ebd518fe6f9c16132765d8don the missing non-interactive agent guard and passes unchanged atdc4d53bSupports pfBlockerNG/pfBlockerNG#3267.