Clarify the adoption and bakery comments, and call vended credentials vended

[coderabbitai]

Rebased onto main: CodeRabbit's comment pass without its p_partition_cols line, which the partitioning change will rewrite, plus "vended"/"issues" in place of "minted" and the base image described as public. Comments and docs only.

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: pgEdge/coldfront/.coderabbit.yaml

Review profile: CHILL

Plan: Essentials

Run ID: d335253f-226e-4e0a-9b97-ee52c635371b

📥 Commits

Reviewing files that changed from the base of the PR and between 8e3441e and 480c732.

⛔ Files ignored due to path filters (1)

• extension/coldfront/test/expected/storage_secret_vended.out is excluded by !**/*.out

📒 Files selected for processing (17)

• .github/workflows/ci-walkthrough.yml
• .github/workflows/ci.yml
• README.md
• ci/journey.sh
• ci/topo/vanilla.sh
• cmd/archiver/main.go
• config.example.yaml
• docs/architecture.md
• docs/changelog.md
• docs/index.md
• docs/object_store.md
• docs/usage.md
• examples/walkthrough/guide.sh
• extension/coldfront/coldfront--1.0.sql
• extension/coldfront/src/coldfront.c
• extension/coldfront/test/sql/storage_secret_vended.sql
• internal/config/config_test.go

Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

---

📝 Walkthrough

Walkthrough

This PR updates vended-credential terminology across documentation and code comments. It also clarifies comments about adoption, transaction handling, workflow permissions, and walkthrough steps. No executable logic changes are described.

Changes

Credential documentation and comments

Layer / File(s)	Summary
Vended credential guidance README.md, ci/journey.sh, ci/topo/vanilla.sh, cmd/archiver/main.go, config.example.yaml, docs/architecture.md, docs/changelog.md, docs/index.md, docs/object_store.md, docs/usage.md, extension/coldfront/coldfront--1.0.sql, extension/coldfront/test/sql/storage_secret_vended.sql, internal/config/config_test.go	Documentation and comments describe Lakekeeper as issuing vended credentials. The usage guide clarifies supported AWS STS and Azure SAS paths, GCS static HMAC credentials, and compactor use of vended credentials.
Adoption and transaction comments extension/coldfront/coldfront--1.0.sql, extension/coldfront/src/coldfront.c	Comments clarify adoption preflight and read-only restrictions, claim reaping, DML rewriting, and deferred bakery-ticket release.
Workflow and walkthrough comments .github/workflows/ci-walkthrough.yml, .github/workflows/ci.yml, examples/walkthrough/guide.sh	Workflow comments revise the base-image description. Walkthrough comments describe the demo adoption flow and cleanup targets.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 480c7

This change updates documentation and comments without changing executable behavior or test expectations. No verified issue remains that should block merging.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 53.85% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 13 functions across 6 files. (11 skipped:…	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately identifies the comment clarifications and the terminology update for vended credentials. It is specific and related to the main changes.
Description check	✅ Passed	The description accurately summarizes the rebase, comment and documentation updates, terminology changes, and base-image wording change.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 53.85% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 13 functions across 6 files. (11 skipped: 11 unsupported.)

• Fix all pre-merge checks with AI

---

_{Comment @coderabbitai help to get the list of available commands.}

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric	Results
Complexity	0
Duplication	0

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.}

[coderabbitai]

✅ Action performed

This PR was authored by the user configured for CodeRabbit reviews. CodeRabbit does not review PRs authored by this user. It's recommended to use a dedicated user account to post CodeRabbit review feedback.

[vyruss]

@coderabbitai review - I updated this PR

[coderabbitai]

@vyruss, I’ll request a review of the updated PR. The earlier author restriction may still prevent the review.

✅ Action performed

This PR was authored by the user configured for CodeRabbit reviews. CodeRabbit does not review PRs authored by this user. It's recommended to use a dedicated user account to post CodeRabbit review feedback.