Skip to content

build: bump Go to 1.26.10 for the eMudhra CA distrust (CVE-2026-111943) - #38

Merged
maqeel75 merged 1 commit into
mainfrom
fix/emudhra-ca-distrust
Oct 29, 2026
Merged

maqeel75 merged 1 commit into
mainfrom
fix/emudhra-ca-distrust

Conversation

@dpage

@dpage dpage commented Oct 27, 2026

Copy link
Copy Markdown
Member

Go releases before 1.26.10 (and 1.27.3) still trust eight compromised eMudhra intermediate CAs (CVE-2026-111943); 1.26.10 adds them to the crypto/x509 denylist, and older Go lines get no fix. This raises the Go version of the tests module to 1.26.10 and pins the setup-go steps in CI to match, along with the stated prerequisite in the README.

Verified locally with go build. go vet (and therefore go test) fails on tests/main.go:524 (non-constant format string in fmt.Errorf), which is already the case on main and is left alone here; the image tests themselves need Docker and were not run.

Go releases before 1.26.10 (and 1.27.3) still trust eight compromised eMudhra intermediate CAs (CVE-2026-111943); 1.26.10 adds them to the crypto/x509 denylist, and older Go lines get no fix. This raises the Go version of the `tests` module to 1.26.10 and pins the `setup-go` steps in CI to match, along with the stated prerequisite in the README.
@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Team
  • Run ID: a50c9ae3-5288-4cc8-8cc4-5b729ec26487
Commits

Reviewing files that changed from the base of the PR and between 1eaebfd and 51be690.

Files selected for processing: 6
  • .github/actions/build-flavor/action.yml
  • .github/workflows/pr_test_latest.yaml
  • .github/workflows/test_images.yaml
  • CHANGELOG.md
  • README.md
  • tests/go.mod

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 8 reviews per hour.

Walkthrough

The Go version changes to 1.26.10 in CI setup, the tests module, and local testing documentation. The Unreleased changelog records the image-test Go version update.

Changes: Go version update

Layer / File(s) Summary
Update Go version references
.github/actions/build-flavor/action.yml, .github/workflows/pr_test_latest.yaml, .github/workflows/test_images.yaml, tests/go.mod, README.md, CHANGELOG.md
CI setup, the tests module, and local testing documentation now specify Go 1.26.10. The Unreleased changelog notes the image-test version update and cites CVE-2026-111943.

Priority: Normal

Merge Risk: Minimal · up to 51be6

No actionable merge-blocking risk was identified in the version update.

Pre-merge checks: Passed 5
Check name Status Explanation
Description check Passed The description clearly explains the Go 1.26.10 upgrade, CI and module changes, README update, security rationale, and verification status.
Title check Passed The title clearly and concisely identifies the main change: upgrading Go to 1.26.10 to address the eMudhra CA distrust vulnerability.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (6 skipped: 6 unsupported.)

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit checks the Go version bright,
Across the workflows, all aligned.
Test notes follow close behind,
The changelog records the change in kind.
One neat update, from paw to page,
Hop along to the next test stage!

Comment @coderabbitai help to get the list of available commands.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@maqeel75
maqeel75 self-requested a review October 29, 2026 14:14
@maqeel75
maqeel75 merged commit 4c784c0 into main Oct 29, 2026
40 checks passed
@maqeel75
maqeel75 deleted the fix/emudhra-ca-distrust branch October 29, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants