Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses our new fork of smithy-rs to change its functionality to support this. The implementation in that fork's PR for this refactor was merged from a pre-existing implementation jplock made.
Why a fork instead of trying to merge upstream? The maintainers of smithy-rs don't want to add support for fips into aws-sigv4.
Why not hand-roll our own implementation for sigv4 that uses aws-lc-rs? We may need to modify other things within smithy to support fips; seemed to make more sense for the long run to have our own fork. It's also a bit cleaner imo to have separation.
I haven't validated the correctness of their commit, since I want to make sure we're okay with going this route first. If we are, I can go through carefully before we merge this, and make sure with certainty everything looks good.
Also: I went ahead and updated the AWS SDK crates to latest while I was doing this.
Corresponding PR: pgdogdev/smithy-rs#2
Fixes #1604