Repository navigation
Enforce Object Lock under the bulk-delete mutation lock - #330
Merged
Merged
Conversation
Signed-off-by: Feng Ruohang <rh@vonng.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S3 DeleteObjects could use stale retention metadata or miss a protected copy in another pool. Physical version removals in Object Lock buckets now use the existing single-object deletion path, which reconciles pool protection and evaluates legal hold, retention and governance bypass under the mutation lock.
Preserve per-item response identities, deduplicate replication work, retain pending purge decisions, and sweep tier objects only after successful deletion. Ordinary buckets and marker creation keep the bulk path. Locked version removals are sequential; the large-batch latency cost is documented.
Add race regressions for concurrent hold/retention updates (including directory null versions), divergent pool copies, mixed/quiet/duplicate responses, governance permissions and replication queue state. Both Go CI and release.yml include the new tests. Clarify batch downgrade boundaries and health-probe limits in CHANGELOG and the retained healthcheck guide.
Validation: targeted bulk-delete race matrix, the complete Object Lock release race gate,
make verifiers, andmake buildpassed. Final runtime acceptance and Linux A/B measurements are being completed before release. Bilingual operational guidance is in pgsty/silo.pgsty.com#56.