Fix ScaleManager scroll bounds after page scrolling#7342
Open
SaveEditors wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7203.
ScaleManagerstores canvas bounds in page coordinates, butgetParentBounds()compared them with viewport-relative coordinates fromgetBoundingClientRect(). After the page scrolled, an unchanged canvas could be treated as having moved and trigger a refresh on every resize interval.The bounds check now converts the current canvas rectangle to page coordinates using the same calculation as
updateBounds()before comparing it with the cached bounds.Regression tests cover horizontal and vertical scrolling, document client borders, parent resizing, actual canvas movement, and fixed-position canvas settling.
Validated on Windows with:
npm test -- tests/scale/ScaleManager.test.js tests/scale/constnpm run buildnode --check src/scale/ScaleManager.jsnode --check tests/scale/ScaleManager.test.jsgit diff --check