Skip to content

fix(verify-routing): check p3-mode's principle index resolves to every leaf - #18

Merged
phob merged 1 commit into
mainfrom
fix/verify-principle-index
Oct 11, 2026
Merged

phob merged 1 commit into
mainfrom
fix/verify-principle-index

Conversation

@phob

@phob phob commented Oct 11, 2026

Copy link
Copy Markdown
Owner

#17 ported upstream's principle index, which names most principles only by title and derives each file from it: kebab case, punctuation dropped. The static refs check found principles by their written-out principle-<name>, so it stopped covering the four that no other skill names: attack-the-premise, experience-first, outcome-oriented-execution, and type-system-discipline. A typo in an index title would have passed.

The new T2 principle-index check derives a leaf from each index entry, or reads the explicit name where an entry gives one. It fails when an entry has no matching principle-* folder, or when a folder has no entry.

Proof. The check passes on main with 24 entries. I renamed "Experience First" to "Experience Firsts" and it failed with no leaf for: [principle-experience-firsts]; not indexed: [principle-experience-first]. I reverted the rename afterward. The p3-mode worker on #17 flagged this gap.

@phob
phob merged commit f231cb9 into main Oct 11, 2026
@coderabbitai

coderabbitai Bot commented Oct 11, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 97c252e6-8274-440b-bce2-090dfae9b041

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@phob
phob deleted the fix/verify-principle-index branch October 11, 2026 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant