Fix CI campaign counting and lifecycle races - #28
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The September 16–21 nightly campaigns failed repeatedly even when Jepsen accepted the histories. The campaign wrapper depends on
rg, which is absent from the runners, and suppresses the command failure before reporting zero successful histories.There are also lifecycle synchronization races: concurrent Jepsen setup threads heal every container while neighboring threads restart them, and two ExUnit regressions treat process registration or route discovery as proof that startup repair or anti-entropy has finished.
Fix
awk, preserving failures from the counter rather than treating them as zero matches. The required history count remains unchanged.Regression coverage exercises a runner without ripgrep, incorrect history counts, command failures, and concurrent node setup.
Supporting information
The September 21 campaign contains both the missing-
rgfailures and an attempt to executeiptablesin a stopped container.This addresses the confirmed harness defects and synchronization races, not every observed nightly failure. The many-cluster and adversarial convergence timeouts, distribution/mixed checker mismatches, and TCP/permanent latency violation still need investigation. No production replication behavior, checker invariant, latency limit, convergence timeout, or soak duration is changed.