Conversation
A user-facing attribute needs a conversion counterpart in the bridge, and `#[Skip]` had none: it passed through to PHPUnit unchanged, where it does nothing and the test would have run.
Testo -> PHPUnit unrolls the attribute into the leading `markTestSkipped()` call PHPUnit has instead, fanning a class-level attribute onto each test method. Both reverse directions now produce the attribute where the source is unconditional — a `markTestSkipped('literal')` opening a test method, and Pest's `->skip('reason')` modifier, which previously became a prepended throw. What stays a `SkipTest` throw is what cannot be declared: a guarded call, one deeper in the body, or a message no attribute argument can hold.
Assisted-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 What was changed
#[Skip]now converts in all three bridge directions instead of passing through untouched — until now it reached PHPUnit unchanged, where it does nothing and the test would simply have run.markTestSkipped()call PHPUnit has instead, fanning a class-level attribute onto each test method and dropping it from the class.markTestSkipped('literal')opening a test method, and Pest's->skip('reason')modifier, which previously became a prepended throw.SkipTestthrow: a guarded call, one deeper in the body, a non-literal message, and amarkTestSkipped()openingsetUp().Why?
A user-facing attribute needs a conversion counterpart in the bridge, and
#[Skip]had none.Checklist
#[Disabled]attribute to declaratively skip a test or test class, with a reason #313 — PR 2 of the incremental plan there (the attribute itself ships in the#[Skip]PR)*.php.incfixture per case in both directions, including the ones deliberately left to the throw rulescomposer test:ci -- --path=bridge/rector— 231 passedDocumentation
FEATURE_PARITY.md, the threeTODO.mdresidual lists and the migration skill's PHPUnit map are updated in the same change.