Skip to content

feat: go watcher - #2716

Closed
AlliBalliBaba wants to merge 19 commits into
mainfrom
feat/go-watcher
Closed

AlliBalliBaba wants to merge 19 commits into
mainfrom
feat/go-watcher

Conversation

@AlliBalliBaba

@AlliBalliBaba AlliBalliBaba commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

This is an experimental branch, moving the watcher to a go-only library (https://github.com/sgtdi/fswatcher).

Not sure if worth it yet, but would potentially simplify dependencies (like not needing libstdc++).

@nickchomey

Copy link
Copy Markdown

FWIW, i'd welcome this change. I wonder if some watcher-related issues might be addressed at the same time?

#2095
#2572
#2708
#2568

@AlliBalliBaba

Copy link
Copy Markdown
Contributor Author

I'll first have to verify the tradeoffs of using this watcher.

But yeah we can add an exclusion pattern. I think #2572 might have already been fixed on main, haven't tried it myself. Moving the watcher to go would also fix #2708 (and hopefully not introduce other issues...). #2568 is an issue in the pecl HTTP extension and needs a fix there (not thread safe on shutdown).

@AlliBalliBaba

Copy link
Copy Markdown
Contributor Author

Nvm, I had big hopes for sgtdi/fswatcher, but I couldn't get it to not crash CI or leak memory on Linux. Let's wait for a better go watcher implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants