Repository navigation
feat: expose frankenphp_thread_index() to C extensions - #2717
Open
nickchomey wants to merge 3 commits into
Open
nickchomey wants to merge 3 commits into
nickchomey wants to merge 3 commits into
Conversation
…hp.h, drop static inline)
Signed-off-by: nickchomey <88559987+nickchomey@users.noreply.github.com>
dunglas
approved these changes
Oct 15, 2026
Author
|
issue was a trailing space in the new comment. fixed with clang-format. CI running now |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commit 52e1932 in #2305 removed the duplicate
frankenphp_thread_indexfrom bothfrankenphp.candfrankenphp.h.However, there wasn't actually a duplicate in
frankenphp.h, so there's no export for frankenstate, frankenasync etc to useAlso, the
frankenphp_thread_indexthat stayed infrankenphp.chasstatic inline, whereas the PR originally did not. So, nothing outside that file can call it.This PR makes the changes that #2305 originally intended. Not sure if that conflicts with anything though.