Replace dependencies on /ext/hash in various extensions#21832
Merged
Conversation
Girgias
reviewed
Jul 8, 2026
Girgias
left a comment
Girgias
left a comment
Member
There was a problem hiding this comment.
Please rebase ontop of latest master rather than merging master into the branch.
| @@ -184,13 +184,7 @@ static inline void php_hash_free_context(const php_hash_ops *ops, void *ctx) { | |||
|
|
|||
| static inline void php_hash_bin2hex(char *out, const unsigned char *in, size_t in_len) | |||
Member
There was a problem hiding this comment.
Does this function still make any sense to exist?
Member
Author
There was a problem hiding this comment.
It doesn't. I was busy removing it at the time you comment 😀
Please rebase ontop of latest master rather than merging master into the branch.
Noted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup-PR for #21724. Using the new API in #21724 to replace dependencies on /ext/hash in
In the following ext, there are independent implementation of bin2hex. This PR also change them to directly using the new Zend API.