.github/actions/apk/action.yml: don't install gnu-libiconv-dev#22645
Open
orlitzky wants to merge 3 commits into
Open
.github/actions/apk/action.yml: don't install gnu-libiconv-dev#22645orlitzky wants to merge 3 commits into
orlitzky wants to merge 3 commits into
Conversation
If we do not install GNU libiconv, the musl libc iconv() implementation should take over, allowing it to be tested on the CI.
There should be no need to pass /usr as an argument to --with-iconv now that the system (libc) implementation is being used.
Member
|
@orlitzky do you know why master is failing with the iconv test changes? |
Contributor
Author
Contributor
Author
|
@Girgias Apologies.. whatever it was must have been my fault. Looking at the diff on #22552 shows the wrong file being changed, but with the "right" commit message. Not sure how I managed to amend and push a commit from a different branch entirely (while dropping the intended one!), but that's what it looks like.
The Alpine CI should confirm that everything wound up as intended in the end. |
This test is for the behavior of iconv's magic "//IGNORE" suffix. The output it expects agrees with POSIX 2024 even when the underlying implementation (glibc) does not. A comment has been added to this effect, and two calls to urlencode() have been removed so that two (expected) errors are not swallowed. Afterwards, we whitelist the two iconv implementations that are known to support //IGNORE. While POSIX standardizes its behavior, it falls short of requiring implementations to support it. Musl in particular does not support any suffix.
Contributor
Author
|
@arnaud-lb I think you set this up initially |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we do not install GNU libiconv, the musl libc
iconv()implementation should take over, allowing it to be tested on the CI.It now passes: https://github.com/php/php-src/actions/runs/28979661263/job/85995230557?pr=22645
This includes the intended fix from #22552 that I lost somehow. In the end, all commits with the correct messages are present.
Closes #22413