Zend: applied fixers to improve test robustness (8/8) - #23316
Open
NickSdot wants to merge 1 commit into
Open
Conversation
NickSdot
changed the title
timsurrealedu
added a commit
to timsurrealedu/php-src
that referenced
this pull request
Aug 18, 2026
Address PR php#23343 review feedback (NickSdot) and CI failures: - Replace hardcoded anonymous-class name expectation leaking the local build path (`string(106) "class@anonymous%0/home/timsurreal/...types.inc:9$1"`) with the canonical EXPECTF pattern `string(%d) "class@anonymous%s"`, matching the convention used by neighboring ZPP tests. The previous form baked in the author's local path and byte length, failing on all CI platforms. Affects: array_ht_or_str, str_or_long, str, zval, string_param (strict + weak). - Replace `PHP_EOL` with `"\n"` in assertion echo lines across all added test files. PHP_EOL is "\r\n" on Windows, a portability hazard per phpGH-23316 and phpGH-22799. All 59 Zend/tests/zpp tests pass locally with zend_test enabled. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asserts error class; extracted from: #22799.
Files with style-only changed were manually reverted.
Split in eight PRs to make reviews easier to digest.