ext/uri: Increases test coverage - #23342
Draft
NickSdot wants to merge 8 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #23286:
This is fully Codex made. I threw a coverage report at it to close uncovered lines/branch gaps. It came up with a tonne of edge cases; this PR is the result of me massaging it a bit, and after filtering out nonsense that did not actually increase coverage as well as things that seemed too esoteric. So everything here increases coverage even though things might seem already tested -- that's because of using slightly different api paths.
Diff will only be useful after #23286 is merged. Won time is noise/variance, not an actual again.