Skip to content

ext/standard: enforce max_filter_count #23344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Sjord wants to merge 1 commit into
base: master
Choose a base branch
from
+27 −29
Draft

ext/standard: enforce max_filter_count #23344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions ext/standard/php_fopen_wrapper.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,12 +152,10 @@ static zend_result php_stream_apply_filter_list(php_stream *stream, char *filter
php_stream_filter *temp_filter;

zend_long max_filter_count = max_filter_count_default;
bool max_filter_count_configured = false;
if (context != NULL) {
zval *option_val = php_stream_context_get_option(context, "filter", "max_filter_count");
if (option_val) {
max_filter_count = zval_get_long(option_val);
max_filter_count_configured = true;
}
}

Expand All @@ -167,13 +165,7 @@ static zend_result php_stream_apply_filter_list(php_stream *stream, char *filter
zend_long write_count = write_chain ? stream->writefilters.num_filters : 0;

if (read_count == max_filter_count || write_count == max_filter_count) {
if (max_filter_count_configured) {
return FAILURE;
} else {
// No max_filter_count configured; raise deprecation error if over default
zend_error(E_DEPRECATED, "Using more than " ZEND_LONG_FMT " filters in a php://filter URL is deprecated, "
"set this limit using the stream context option max_filter_count, or use stream_filter_append", max_filter_count_default);
}
return FAILURE;
}

php_url_decode(p, strlen(p));
Expand Down
46 changes: 26 additions & 20 deletions ext/standard/tests/filters/max_filter_chain.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,24 +90,30 @@ int(1)
int(1)
# file_get_contents on 17 filters

Deprecated: Using more than 16 filters in a php://filter URL is deprecated, set this limit using the stream context option max_filter_count, or use stream_filter_append in %smax_filter_chain.php on line %d
string(9) "SEVENTEEN"
Warning: file_get_contents(): Failed to open stream: too many filters in %s on line %d
bool(false)

Deprecated: Using more than 16 filters in a php://filter URL is deprecated, set this limit using the stream context option max_filter_count, or use stream_filter_append in %smax_filter_chain.php on line %d
string(9) "SEVENTEEN"
Warning: file_get_contents(): Failed to open stream: too many filters in %s on line %d
bool(false)

Deprecated: Using more than 16 filters in a php://filter URL is deprecated, set this limit using the stream context option max_filter_count, or use stream_filter_append in %smax_filter_chain.php on line %d
string(9) "SEVENTEEN"
Warning: file_get_contents(): Failed to open stream: too many filters in %s on line %d
bool(false)
# include on 17 filters

Deprecated: Using more than 16 filters in a php://filter URL is deprecated, set this limit using the stream context option max_filter_count, or use stream_filter_append in %smax_filter_chain.php on line %d
int(1)
Warning: include(): Failed to open stream: too many filters in %s on line %d

Deprecated: Using more than 16 filters in a php://filter URL is deprecated, set this limit using the stream context option max_filter_count, or use stream_filter_append in %smax_filter_chain.php on line %d
int(1)
Warning: include(): Failed opening %s
bool(false)

Deprecated: Using more than 16 filters in a php://filter URL is deprecated, set this limit using the stream context option max_filter_count, or use stream_filter_append in %smax_filter_chain.php on line %d
int(1)
Warning: include(): Failed to open stream: too many filters in %s on line %d

Warning: include(): Failed opening %s
bool(false)

Warning: include(): Failed to open stream: too many filters in %s on line %d

Warning: include(): Failed opening %s
bool(false)
# file_get_contents on 3 filters, max_filter_count=2

Warning: file_get_contents(): Failed to open stream: too many filters in %s on line %d
Expand All @@ -124,18 +130,18 @@ string(8) "NINETEEN"
string(8) "NINETEEN"
# warning is only given once, even when we add two filters over the limit

Deprecated: Using more than 16 filters in a php://filter URL is deprecated, set this limit using the stream context option max_filter_count, or use stream_filter_append in %smax_filter_chain.php on line %d
string(8) "EIGHTEEN"
Warning: file_get_contents(): Failed to open stream: too many filters in %s on line %d
bool(false)

Deprecated: Using more than 16 filters in a php://filter URL is deprecated, set this limit using the stream context option max_filter_count, or use stream_filter_append in %smax_filter_chain.php on line %d
string(8) "EIGHTEEN"
Warning: file_get_contents(): Failed to open stream: too many filters in %s on line %d
bool(false)

Deprecated: Using more than 16 filters in a php://filter URL is deprecated, set this limit using the stream context option max_filter_count, or use stream_filter_append in %smax_filter_chain.php on line %d
string(8) "EIGHTEEN"
Warning: file_get_contents(): Failed to open stream: operation failed in %s on line %d
bool(false)
# warn on too many write filters, even when number of read filters is OK

Deprecated: Using more than 16 filters in a php://filter URL is deprecated, set this limit using the stream context option max_filter_count, or use stream_filter_append in %smax_filter_chain.php on line %d
bool(true)
Warning: fopen(): Failed to open stream: too many filters in %s on line %d
bool(false)
# setting max_filter_count to -1 disables warning
string(6) "TWENTY"
string(6) "TWENTY"
Expand Down
Loading